Unify the version string to be displayed on "About Chromium" dialog. (2.5/6)

Unify the version string to be displayed on "About Chromium" dialog. (2.5/6)

- This patch just changes the width of "About Chromium" dialog to 530px.

FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the extra fix for the second step of them:

(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)

BUG=37186
TEST=Observe that the "About Chromium" dialog on Mac has a reasonable width for showing the version string in one line.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94079

[haraken1, 2011-07-26 00:37:01]

On 2011/07/25 13:28:33, Mark Mentovai wrote:
> Now that this is in today’s Canary and I’ve had a chance to see it, I wonder
if
> 550px is too wide. Would 500 suffice?

I changed the width of "About Chromium" dialog to 500px. A screenshot is here:
http://haraken.info/null/about_dialog.png

mark: would you please take a look?
tony: FYI

[Mark Mentovai, 2011-07-26 01:04:15]

From that screen shot, I think 450px would have been fine, but let’s try this
first. LGTM.

[haraken1, 2011-07-26 01:50:13]

Sorry, I found that 500px is not enough. I changed it to 530px. 

This is a screenshot for the corner case:
http://haraken.info/null/about_dialog3.png


On 2011/07/26 01:04:15, Mark Mentovai wrote:
> From that screen shot, I think 450px would have been fine, but let’s try this
> first. LGTM.

[Mark Mentovai, 2011-07-26 02:58:34]

There’s so much vertical space, why don’t we just bump the extra
information to a new line and go back to a narrower window?

I don’t want to optimize for that pathological case in unofficial
builds and leave it so wide with so much extra horizontal whitespace
in official builds.

[haraken1, 2011-07-26 03:46:35]

No change for now. 

> There’s so much vertical space, why don’t we just bump the extra
> information to a new line and go back to a narrower window?

In the first place, the motivation of this change is to draw full version
information in one line, so that people can easily copy and paste it to our bug
site or something. So, we should not split the information into two lines. 

> I don’t want to optimize for that pathological case in unofficial
> builds and leave it so wide with so much extra horizontal whitespace
> in official builds.

OK. However, 450px is a bit too narrow. It always overflows for unofficial
builds: http://haraken.info/null/about_dialog2.png

450px: always overflow for unofficial builds
500px: not overflow for most unofficial builds
530px: never overflow for all builds

I guess that 500px is best but what do you think?

[Mark Mentovai, 2011-07-26 03:57:01]

I think that 500px is the best compromise for now.

We really really really shouldn’t make the official builds ugly by
having so much horizontal whitespace just to make things a tiny bit
easier for unofficial developer builds.

For that matter, there’s nothing about a multiline field that would
render it not selectable/copyable as a whole.

[haraken1, 2011-07-26 04:12:39]

Sure. In that case, I would like to commit this patch with 500px, but is it OK?

> We really really really shouldn’t make the official builds ugly by
> having so much horizontal whitespace just to make things a tiny bit
> easier for unofficial developer builds. For that matter, 
> there’s nothing about a multiline field that would
> render it not selectable/copyable as a whole.

I agree with you, but I think that we need to discuss it as another CL if we
want to make it multiline. Linux Chromium also has much horizontal whitespaces. 


On 2011/07/26 03:57:01, Mark Mentovai wrote:
> I think that 500px is the best compromise for now.
> 
> We really really really shouldn’t make the official builds ugly by
> having so much horizontal whitespace just to make things a tiny bit
> easier for unofficial developer builds.
> 
> For that matter, there’s nothing about a multiline field that would
> render it not selectable/copyable as a whole.

[Mark Mentovai, 2011-07-26 04:25:04]

LGTM. 500 for now and I expect you can make a final pass for visual
tweaks once you’re done getting the major parts checked in.

[commit-bot: I haz the power, 2011-07-26 11:42:19]

Change committed as 94079