Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 7461058: Unify the version string to be displayed on "About Chromium" dialog. (2/6) (Closed)

Created:
9 years, 5 months ago by haraken1
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Unify the version string to be displayed on "About Chromium" dialog. (2/6) We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the second step of them: (1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony) (2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark) (3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony) (4) Update version.bat to use lastchange.py. (reviewer: evan) (5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark) (6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan) BUG=37186 TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Mac)" on Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93836

Patch Set 1 : Step 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -37 lines) Patch
M chrome/app/nibs/About.xib View 19 chunks +48 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/about_window_controller.mm View 1 chunk +2 lines, -18 lines 0 comments Download
M chrome/common/chrome_version_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken1
mark: Would you please take a look at it? tony: FYI
9 years, 5 months ago (2011-07-25 01:49:52 UTC) #1
Mark Mentovai
LGTM. Please also Cc me on the reviews for steps 5 and 6 when those ...
9 years, 5 months ago (2011-07-25 01:55:17 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-25 02:54:32 UTC) #3
Change committed as 93836

Powered by Google App Engine
This is Rietveld 408576698