Issue 7461018: Implement for..in for FastDoubleArrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7461018: Implement for..in for FastDoubleArrays (Closed)

Created:
9 years, 5 months ago by danno

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Implement for..in for FastDoubleArrays Also add tests for apply on FastDoubleArrays. R=ager@chromium.org BUG=none TEST=unboxed-double-array.js Committed: http://code.google.com/p/v8/source/detail?r=8693

Patch Set 1 #

Patch Set 2 : uncomment test #

Total comments: 1

Patch Set 3 : review feedback #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -6 lines)			Patch
	M	src/objects.cc	View	1 2	4 chunks	+24 lines, -6 lines	0 comments	Download
	M	test/mjsunit/unbox-double-arrays.js	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/7461018/diff/2002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7461018/diff/2002/src/objects.cc#newcode9641 src/objects.cc:9641: case FAST_DOUBLE_ELEMENTS: { Move this to right after ...

9 years, 5 months ago (2011-07-20 10:10:29 UTC) #2

Incorporated feedback, landing.

Expand Messages | Collapse Messages