Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: media/base/filters.h

Issue 7461016: Replace VideoDecoder::media_format() with significantly simpler width()/height() methods. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: fixes Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index e541c78d6c1a519710a5031777024ba55cc035b5..ffd7201adf8cfbf6bc1b044365fec2952879413b 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -225,8 +225,15 @@ class VideoDecoder : public Filter {
// Indicate whether decoder provides its own output buffers
virtual bool ProvidesBuffer() = 0;
- // Returns the media format produced by this decoder.
- virtual const MediaFormat& media_format() = 0;
+ // Returns the width and height of decoded video in pixels.
+ //
+ // Clients should NOT rely on these values to remain constant. Instead, use
+ // the width/height from decoded video frames themselves.
+ //
+ // TODO(scherkus): why not rely on prerolling and decoding a single frame to
+ // get dimensions?
+ virtual int width() = 0;
+ virtual int height() = 0;
protected:
// Executes the permanent callback to pass off decoded video.
« no previous file with comments | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698