media/base/filters.h - Issue 7461016: Replace VideoDecoder::media_format() with significantly simpler width()/height() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/filters.h

Issue 7461016: Replace VideoDecoder::media_format() with significantly simpler width()/height() methods. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/rtc_video_decoder.cc ('K') | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | media/base/mock_filters.h » ('j') | media/filters/video_renderer_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/filters.h

diff --git a/media/base/filters.h b/media/base/filters.h

index e541c78d6c1a519710a5031777024ba55cc035b5..ffd7201adf8cfbf6bc1b044365fec2952879413b 100644

--- a/media/base/filters.h

+++ b/media/base/filters.h

@@ -225,8 +225,15 @@ class VideoDecoder : public Filter {

// Indicate whether decoder provides its own output buffers

virtual bool ProvidesBuffer() = 0;

- // Returns the media format produced by this decoder.

- virtual const MediaFormat& media_format() = 0;

+ // Returns the width and height of decoded video in pixels.

+ //

+ // Clients should NOT rely on these values to remain constant. Instead, use

+ // the width/height from decoded video frames themselves.

+ //

+ // TODO(scherkus): why not rely on prerolling and decoding a single frame to

+ // get dimensions?

+ virtual int width() = 0;

+ virtual int height() = 0;

protected:

// Executes the permanent callback to pass off decoded video.