Replace VideoDecoder::media_format() with significantly simpler width()/height() methods.

webkit/glue/media/video_renderer_impl.cc

Index: webkit/glue/media/video_renderer_impl.cc
diff --git a/webkit/glue/media/video_renderer_impl.cc b/webkit/glue/media/video_renderer_impl.cc
index 5e159fee292880ee1c567b1997f1f2b15b7d1546..c05ac9952d5b489c195b8f07e21accfeb584aa44 100644
--- a/webkit/glue/media/video_renderer_impl.cc
+++ b/webkit/glue/media/video_renderer_impl.cc
@@ -18,15 +18,12 @@ VideoRendererImpl::VideoRendererImpl(bool pts_logging)
 VideoRendererImpl::~VideoRendererImpl() {}
 
 bool VideoRendererImpl::OnInitialize(media::VideoDecoder* decoder) {
-  video_size_.SetSize(width(), height());
-  bitmap_.setConfig(SkBitmap::kARGB_8888_Config, width(), height());
-  if (bitmap_.allocPixels(NULL, NULL)) {
-    bitmap_.eraseRGB(0x00, 0x00, 0x00);
-    return true;
-  }
-
-  NOTREACHED();
-  return false;
+  video_size_.SetSize(decoder->width(), decoder->height());
+  bitmap_.setConfig(SkBitmap::kARGB_8888_Config,
+                    decoder->width(), decoder->height());
+  bitmap_.allocPixels();

[Ami GONE FROM CHROMIUM, 2011/07/20 16:30:22]

CHECK it?

[scherkus (not reviewing), 2011/07/20 16:51:52]

most chromium code simply assumes the call will work

if allocation fails inside this method the whole process is killed anyway :(

[Ami GONE FROM CHROMIUM, 2011/07/20 16:56:26]

I wish code like this had a compile-time flag that s/bool/void/ for build
configs like chromium's.

+  bitmap_.eraseRGB(0x00, 0x00, 0x00);
+  return true;
 }
 
 void VideoRendererImpl::OnStop(media::FilterCallback* callback) {