Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/runtime.cc

Issue 7460009: Make proxy fixing GC safe. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 ASSERT(args.length() == 1); 612 ASSERT(args.length() == 1);
613 CONVERT_CHECKED(JSProxy, proxy, args[0]); 613 CONVERT_CHECKED(JSProxy, proxy, args[0]);
614 return proxy->handler(); 614 return proxy->handler();
615 } 615 }
616 616
617 617
618 RUNTIME_FUNCTION(MaybeObject*, Runtime_Fix) { 618 RUNTIME_FUNCTION(MaybeObject*, Runtime_Fix) {
619 ASSERT(args.length() == 1); 619 ASSERT(args.length() == 1);
620 CONVERT_CHECKED(JSProxy, proxy, args[0]); 620 CONVERT_CHECKED(JSProxy, proxy, args[0]);
621 proxy->Fix(); 621 proxy->Fix();
622 return proxy; 622 return isolate->heap()->undefined_value();
623 } 623 }
624 624
625 625
626 RUNTIME_FUNCTION(MaybeObject*, Runtime_ClassOf) { 626 RUNTIME_FUNCTION(MaybeObject*, Runtime_ClassOf) {
627 NoHandleAllocation ha; 627 NoHandleAllocation ha;
628 ASSERT(args.length() == 1); 628 ASSERT(args.length() == 1);
629 Object* obj = args[0]; 629 Object* obj = args[0];
630 if (!obj->IsJSObject()) return isolate->heap()->null_value(); 630 if (!obj->IsJSObject()) return isolate->heap()->null_value();
631 return JSObject::cast(obj)->class_name(); 631 return JSObject::cast(obj)->class_name();
632 } 632 }
(...skipping 12062 matching lines...) Expand 10 before | Expand all | Expand 10 after
12695 } else { 12695 } else {
12696 // Handle last resort GC and make sure to allow future allocations 12696 // Handle last resort GC and make sure to allow future allocations
12697 // to grow the heap without causing GCs (if possible). 12697 // to grow the heap without causing GCs (if possible).
12698 isolate->counters()->gc_last_resort_from_js()->Increment(); 12698 isolate->counters()->gc_last_resort_from_js()->Increment();
12699 isolate->heap()->CollectAllGarbage(false); 12699 isolate->heap()->CollectAllGarbage(false);
12700 } 12700 }
12701 } 12701 }
12702 12702
12703 12703
12704 } } // namespace v8::internal 12704 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698