Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 7459007: Fix for issue 1566: added flushing after writing to stdout. (Closed)

Created:
9 years, 5 months ago by Yang
Modified:
9 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix for issue 1566: added flushing after writing to stdout. BUG=v8:1566 Committed: http://code.google.com/p/v8/source/detail?r=8694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Somebody sent an issue that d8 didn't flush stdout buffer when killed by a signal. ...
9 years, 5 months ago (2011-07-20 12:47:31 UTC) #1
Jakob Kummerow
9 years, 5 months ago (2011-07-20 13:12:24 UTC) #2
LGTM with a nit:

Please update the CL description so that the bug line says:
BUG=v8:1566
That's shorter, and you'll get a nice auto-generated link to the bug :-)
(Just don't forget the "v8:" part, or it'll auto-link to the Chromium bug with
that number.)

Powered by Google App Engine
This is Rietveld 408576698