Chromium Code Reviews| Index: base/bind_unittest.nc |
| diff --git a/base/bind_unittest.nc b/base/bind_unittest.nc |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..400abe28cb44364e753fc0182e2760dae8c0e108 |
| --- /dev/null |
| +++ b/base/bind_unittest.nc |
| @@ -0,0 +1,218 @@ |
| +// Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#include "base/callback.h" |
| +#include "base/bind.h" |
| + |
| +namespace base { |
| + |
| +// Keep all the test declarations outside of an anonymous namespace to avoid |
|
Ami GONE FROM CHROMIUM
2011/09/09 17:17:12
Umm, what?
awong
2011/09/09 18:56:31
Clarified.
|
| +// unused definition warnings. |
| +const int kParentValue = 1; |
|
Ami GONE FROM CHROMIUM
2011/09/09 17:17:12
static is implied so I enjoy putting it in explici
awong
2011/09/09 18:56:31
Done.
|
| +const int kChildValue = 2; |
| + |
| +class NoRef { |
| + public: |
| + void VoidMethod0() {} |
| + void VoidConstMethod0() const {} |
| + int IntMethod0() { return 1; } |
| +}; |
| + |
| +class HasRef : public NoRef { |
| + public: |
| + void AddRef(void) const {} |
| + bool Release(void) const { return true; } |
| +}; |
| + |
| +class Parent { |
| + public: |
| + void AddRef(void) const {} |
| + void Release(void) const {} |
| + virtual void VirtualSet() { value = kParentValue; } |
| + void NonVirtualSet() { value = kParentValue; } |
| + int value; |
| +}; |
| + |
| +class Child : public Parent { |
| + public: |
| + virtual void VirtualSet() { value = kChildValue; } |
| + void NonVirtualSet() { value = kChildValue; } |
| +}; |
| + |
| +class NoRefParent { |
| + public: |
| + virtual void VirtualSet() { value = kParentValue; } |
| + void NonVirtualSet() { value = kParentValue; } |
| + int value; |
| +}; |
| + |
| +class NoRefChild : public NoRefParent { |
| + virtual void VirtualSet() { value = kChildValue; } |
| + void NonVirtualSet() { value = kChildValue; } |
| +}; |
| + |
| +template <typename T> |
| +T PolymorphicIdentity(T t) { |
| + return t; |
| +} |
| + |
| +int UnwrapParentRef(Parent& p) { |
| + return p.value; |
| +} |
| + |
| +template <typename T> |
| +void VoidPolymorphic1(T t) { |
| +} |
| + |
| +#if defined(NCTEST_METHOD_ON_CONST_OBJECT) // [r"invalid conversion from 'const base::NoRef\*' to 'base::NoRef\*'"] |
| + |
| +// Method bound to const-object. |
| +// |
| +// Only const methods should be allowed to work with const objects. |
| +void WontCompile() { |
| + HasRef has_ref; |
| + const HasRef* const_has_ref_ptr_ = &has_ref; |
| + Callback<void(void)> method_to_const_cb = |
| + Bind(&HasRef::VoidMethod0, const_has_ref_ptr_); |
| + method_to_const_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_CONSTRUCTION_FROM_SUBTYPE) // [r"conversion from 'base::Callback<int\(\)>' to non-scalar type 'base::Callback<void\(\)>'"] |
| + |
| +// Construction of Callback<A> from Callback<B> if A is supertype of B. |
| +// |
| +// While this is technically safe, most people aren't used to it when coding |
| +// C++ so if this is happening, it is almost certainly an error. |
| +void WontCompile() { |
| + Callback<int(void)> cb_a = Bind(&PolymorphicIdentity<int>, 1); |
| + Callback<void(void)> cb_b = cb_a; |
| +} |
| + |
| +#elif defined(NCTEST_ASSIGNMENT_FROM_SUBTYPE) // [r"no match for 'operator=' in 'cb_a = cb_b'"] |
| + |
| +// Assignment of Callback<A> from Callback<B> if A is supertype of B. |
| +// See explanation for NCTEST_CONSTRUCTION_FROM_SUBTYPE |
| +void WontCompile() { |
| + Callback<int(void)> cb_a = Bind(&PolymorphicIdentity<int>, 1); |
| + Callback<void(void)> cb_b; |
| + cb_a = cb_b; |
| +} |
| + |
| +#elif defined(NCTEST_METHOD_BIND_NEEDS_REFCOUNTED_OBJECT) // [r"has no member named 'AddRef'"] |
| + |
| +// Method bound to non-refcounted object. |
| +// |
| +// We require refcounts unless you have Unretained(). |
| +void WontCompile() { |
| + NoRef no_ref; |
| + Callback<void(void)> no_ref_cb = |
| + Bind(&NoRef::VoidMethod0, &no_ref); |
| + no_ref_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_CONST_METHOD_NEEDS_REFCOUNTED_OBJECT) // [r"has no member named 'AddRef'"] |
| + |
| +// Const Method bound to non-refcounted object. |
| +// |
| +// We require refcounts unless you have Unretained(). |
| +void WontCompile() { |
| + NoRef no_ref; |
| + Callback<void(void)> no_ref_const_cb = |
| + Bind(&NoRef::VoidConstMethod0, &no_ref); |
| + no_ref_const_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_CONST_POINTER) // [r"invalid conversion from 'const base::NoRef\*' to 'base::NoRef\*'"] |
| + |
| +// Const argument used with non-const pointer parameter of same type. |
| +// |
| +// This is just a const-correctness check. |
| +void WontCompile() { |
| + const NoRef* const_no_ref_ptr; |
| + Callback<NoRef*(void)> pointer_same_cb = |
| + Bind(&PolymorphicIdentity<NoRef*>, const_no_ref_ptr); |
| + pointer_same_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_CONST_POINTER_SUBTYPE) // [r"'const base::NoRefParent\*' to 'base::NoRefParent\*'"] |
| + |
| +// Const argument used with non-const pointer parameter of super type. |
| +// |
| +// This is just a const-correctness check. |
| +void WontCompile() { |
| + const NoRefChild* const_child_ptr; |
| + Callback<NoRefParent*(void)> pointer_super_cb = |
| + Bind(&PolymorphicIdentity<NoRefParent*>, const_child_ptr); |
| + pointer_super_cb.Run(); |
| +} |
| + |
| +#elif defined(DISABLED_NCTEST_DISALLOW_NON_CONST_REF_PARAM) // [r"badstring"] |
| + |
| +// Functions with reference parameters, unsupported. |
| +// |
| +// First, non-const reference parameters are disallowed by the Google |
| +// style guide. Second, since we are doing argument forwarding it becomes |
| +// very tricky to avoid copies, maintain const correctness, and not |
| +// accidentally have the function be modifying a temporary, or a copy. |
| +void WontCompile() { |
| + Parent p; |
| + Callback<int(Parent&)> ref_arg_cb = Bind(&UnwrapParentRef); |
| + ref_arg_cb.Run(p); |
| +} |
| + |
| +#elif defined(NCTEST_DISALLOW_BIND_TO_NON_CONST_REF_PARAM) // [r"creating array with negative size"] |
| + |
| +// Binding functions with reference parameters, unsupported. |
| +// |
| +// See comment in NCTEST_DISALLOW_NON_CONST_REF_PARAM |
| +void WontCompile() { |
| + Parent p; |
| + Callback<int(void)> ref_cb = Bind(&UnwrapParentRef, p); |
| + ref_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_NO_IMPLICIT_ARRAY_PTR_CONVERSION) // [r"creating array with negative size"] |
| + |
| +// A method should not be bindable with an array of objects. |
| +// |
| +// This is likely not wanted behavior. We specifically check for it though |
| +// because it is possible, depending on how you implement prebinding, to |
| +// implicitly convert an array type to a pointer type. |
| +void WontCompile() { |
| + HasRef p[10]; |
| + Callback<void(void)> method_bound_to_array_cb = |
| + Bind(&HasRef::VoidMethod0, p); |
| + method_bound_to_array_cb.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_NO_RAW_PTR_FOR_REFCOUNTED_TYPES) // [r"creating array with negative size"] |
| + |
| +// Refcounted types should not be bound as a raw pointer. |
| +void WontCompile() { |
| + HasRef for_raw_ptr; |
| + Callback<void(void)> ref_count_as_raw_ptr = |
| + Bind(&VoidPolymorphic1<HasRef*>, &for_raw_ptr); |
| +} |
| + |
| +#elif defined(NCTEST_WEAKPTR_BIND_MUST_RETURN_VOID) // [r"creating array with negative size"] |
| + |
| +// WeakPtrs cannot be bound to methods with return types. |
| +void WontCompile() { |
| + NoRef no_ref; |
| + WeakPtrFactory<NoRef> weak_factory(&no_ref); |
| + Callback<int(void)> weak_ptr_with_non_void_return_type = |
| + Bind(&NoRef::IntMethod0, weak_factory.GetWeakPtr()); |
| + weak_ptr_with_non_void_return_type.Run(); |
| +} |
| + |
| +#elif defined(NCTEST_DISALLOW_ASSIGN_DIFFERINT_TYPES) // [r"creating array with negative size"] |
| + |
| +// Bind result cannot be assigned to Callbacks with a mismatching type. |
| +void WontCompile() { |
| + Closure callback_mismatches_bind_type = Bind(&VoidPolymorphic1<int>); |
| +} |
| + |
| +#endif |
| + |
| +} // namespace base |