Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: gpu/command_buffer/service/cmd_parser_test.cc

Issue 7458010: Revert 93066 - Execute all GL commands up to the put offset reported by a each flush.This means g... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/cmd_parser.cc ('k') | gpu/command_buffer/service/command_buffer_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/cmd_parser_test.cc
===================================================================
--- gpu/command_buffer/service/cmd_parser_test.cc (revision 93137)
+++ gpu/command_buffer/service/cmd_parser_test.cc (working copy)
@@ -288,4 +288,28 @@
Mock::VerifyAndClearExpectations(api_mock());
}
+TEST_F(CommandParserTest, TestWaiting) {
+ const unsigned int kNumEntries = 5;
+ scoped_ptr<CommandParser> parser(MakeParser(kNumEntries));
+ CommandBufferOffset put = parser->put();
+ CommandHeader header;
+
+ // Generate a command with size 1.
+ header.size = 1;
+ header.command = 3;
+ buffer()[put++].value_header = header;
+
+ parser->set_put(put);
+ // A command that returns kWaiting should not advance the get pointer.
+ AddDoCommandExpect(error::kWaiting, 3, 0, NULL);
+ EXPECT_EQ(error::kWaiting, parser->ProcessAllCommands());
+ EXPECT_EQ(0, parser->get());
+ Mock::VerifyAndClearExpectations(api_mock());
+ // Not waiting should advance the get pointer.
+ AddDoCommandExpect(error::kNoError, 3, 0, NULL);
+ EXPECT_EQ(error::kNoError, parser->ProcessAllCommands());
+ EXPECT_EQ(put, parser->get());
+ Mock::VerifyAndClearExpectations(api_mock());
+}
+
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/cmd_parser.cc ('k') | gpu/command_buffer/service/command_buffer_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698