Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: gpu/command_buffer/common/command_buffer.h

Issue 7458010: Revert 93066 - Execute all GL commands up to the put offset reported by a each flush.This means g... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/common/cmd_buffer_common.cc ('k') | gpu/command_buffer/common/command_buffer_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/common/command_buffer.h
===================================================================
--- gpu/command_buffer/common/command_buffer.h (revision 93137)
+++ gpu/command_buffer/common/command_buffer.h (working copy)
@@ -78,18 +78,17 @@
// Returns the current status.
virtual State GetState() = 0;
- // Returns the last state without synchronizing with the service.
- virtual State GetLastState();
-
// The writer calls this to update its put offset. This ensures the reader
- // sees the latest added commands, and will eventually process them. On the
- // service side, commands are processed up to the given put_offset before
- // subsequent Flushes on the same GpuChannel.
+ // sees the latest added commands, and will eventually process them.
virtual void Flush(int32 put_offset) = 0;
// The writer calls this to update its put offset. This function returns the
- // reader's most recent get offset. Does not return until all pending commands
- // have been executed.
+ // reader's most recent get offset. Does not return until after the put offset
+ // change callback has been invoked. Returns -1 if the put offset is invalid.
+ // If last_known_get is different from the reader's current get pointer, this
+ // function will return immediately, otherwise it guarantees that the reader
+ // has processed some commands before returning (assuming the command buffer
+ // isn't empty and there is no error).
virtual State FlushSync(int32 put_offset, int32 last_known_get) = 0;
// Sets the current get offset. This can be called from any thread.
« no previous file with comments | « gpu/command_buffer/common/cmd_buffer_common.cc ('k') | gpu/command_buffer/common/command_buffer_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698