Fix linux redux build

Fix linux redux build

Follow up to http://codereview.chromium.org/7342047/
stl_util.h seems out of favor, so calling stl method directly as required.


BUG=None
TEST=Greeness on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Redux/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93181

[joth, 2011-07-20 11:03:17]

(The call to assign instead of swap is not part of the build fix, just a
nano-optimization)

[joth, 2011-07-20 11:04:26]

+agl for OWNERS rubber stamp, although I'll probably land this anyway to fix the
build.
Ta!

[bulach, 2011-07-20 11:06:02]

LGTM

http://codereview.chromium.org/7457021/diff/1/crypto/rsa_private_key_openssl.cc
File crypto/rsa_private_key_openssl.cc (right):

http://codereview.chromium.org/7457021/diff/1/crypto/rsa_private_key_openssl....
crypto/rsa_private_key_openssl.cc:43: output->assign(data, data+len);
nit: data + len

[Denis Lagno, 2011-07-20 11:13:59]

http://codereview.chromium.org/7457021/diff/3001/crypto/rsa_private_key_opens...
File crypto/rsa_private_key_openssl.cc (left):

http://codereview.chromium.org/7457021/diff/3001/crypto/rsa_private_key_opens...
crypto/rsa_private_key_openssl.cc:83: vector_as_array(&input)));
> stl_util.h seems out of favor, so calling stl method directly as required

some methods from stl_util are still widely used and there are no plans to get
rid of them.
I would not discourage anybody from using vector_as_array.

[joth, 2011-07-20 11:20:46]

On 2011/07/20 11:13:59, Denis Lagno wrote:
>
http://codereview.chromium.org/7457021/diff/3001/crypto/rsa_private_key_opens...
> File crypto/rsa_private_key_openssl.cc (left):
> 
>
http://codereview.chromium.org/7457021/diff/3001/crypto/rsa_private_key_opens...
> crypto/rsa_private_key_openssl.cc:83: vector_as_array(&input)));
> > stl_util.h seems out of favor, so calling stl method directly as required
> 
> some methods from stl_util are still widely used and there are no plans to get
> rid of them.
> I would not discourage anybody from using vector_as_array.

Ah, OK.
I read the description of vector_as_array and looked at the _mac version of of
rsa_private_key, and decided it's cleaner to have explicit handling of empty
input anyway.

Thanks for the quick reply.

[agl, 2011-07-20 14:07:41]

LGTM