Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 7457019: Make window.undefined, window.NaN, window.Infinitiy read-only (ES5 section 15.1.1) (Closed)

Created:
9 years, 5 months ago by Jakob Kummerow
Modified:
9 years, 5 months ago
Reviewers:
danno
CC:
v8-dev, Mads Ager (chromium)
Visibility:
Public.

Description

Make window.undefined, window.NaN, window.Infinitiy read-only (ES5 section 15.1.1) BUG=89490 TEST=manual: "Infinity = 42;" doesn't change the value of "Infinity" Committed: http://code.google.com/p/v8/source/detail?r=8691

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M src/v8natives.js View 1 chunk +4 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-89490.js View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL.
9 years, 5 months ago (2011-07-20 09:20:45 UTC) #1
danno
Is it possible to add a test case for this?
9 years, 5 months ago (2011-07-20 09:22:39 UTC) #2
Jakob Kummerow
Here you go.
9 years, 5 months ago (2011-07-20 09:32:01 UTC) #3
danno
9 years, 5 months ago (2011-07-20 09:58:44 UTC) #4
LTGM

Powered by Google App Engine
This is Rietveld 408576698