Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 7457018: Fix presubmit error in copyright message. (Closed)

Created:
9 years, 5 months ago by William Hesse
Modified:
9 years, 5 months ago
Reviewers:
wingo, fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix presubmit error in copyright message. Use new gcc flag -Wno-unused-but-set-variable only on linux. TBR=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8689

Patch Set 1 #

Patch Set 2 : Rebase git. #

Patch Set 3 : Restrict use of new gcc flag to linux platform. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M SConstruct View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/jsregexp.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
TBR=fschneider@chromium.org.
9 years, 5 months ago (2011-07-20 08:36:07 UTC) #1
fschneider
9 years, 5 months ago (2011-07-20 10:32:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698