Issue 7457010: Remove IPCSyncChannelTest.BadMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7457010: Remove IPCSyncChannelTest.BadMessage (Closed)

Created:
9 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 5 months ago

Reviewers:
agl

CC:
chromium-reviews, darin-cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove IPCSyncChannelTest.BadMessage The test was trying to check that a DCHECK is being hit, but it's not really the best thing to do. BUG=62511 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93207

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -60 lines)			Patch
	M	ipc/ipc_sync_channel_unittest.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

I got John's (jam) OK for this on IM, but added you as a reviewer ...

9 years, 5 months ago (2011-07-19 23:29:56 UTC) #1

LGTM