Adding support for mount point different from removable devices to MountLibrary

chrome/common/extensions/api/extension_api.json

Index: chrome/common/extensions/api/extension_api.json
===================================================================
--- chrome/common/extensions/api/extension_api.json	(revision 93425)
+++ chrome/common/extensions/api/extension_api.json	(working copy)
@@ -5172,6 +5172,13 @@
         }
       },
       {
+        "id": "MountType",

[zel, 2011/07/22 21:12:23]

remove this type, see below

[tbarzic, 2011/07/22 22:04:48]

Done.

+        "type": "string",
+        "enum": ["device", "file", "network"],
+        "description": "Type of the mount."
+        
+      },
+      {
         "id": "VolumeMetadata",
         "type": "object",
         "description": "Mounted disk volume metadata.",
@@ -5244,6 +5251,33 @@
         }
       },
       {
+        "id": "MountCompletedEvent",
+        "type": "object",
+        "description": "Payload data for mount event.",
+        "properties": {
+          "eventType": {

[zel, 2011/07/22 21:12:23]

let's make eventType being just 'mount', 'unmount' and add
another field called 'status' that will have success/error values as:


  success, 
  error_unknown,
  error_internal,
  ...

and make sure you prefix all error conditions with error_*

[tbarzic, 2011/07/22 22:04:48]

Done.

+            "type": "string",
+            "enum": ["success", "unknown", "internal", "unknown_filesystem",
+                     "unsuported_filesystem", "invalid_archive",
+                     "libcros_missing", "path_unmounted"],
+            "description": "Event type that tells listeners if mount was successfull or an error occurred. It also specifies the error."
+          },
+          "sourcePath": {
+            "type": "string",
+            "description": "Path that has been mounted."
+          },
+          "mountPath": {
+            "type": "string",
+            "optional": true,
+            "description": "Path that sourcePath was mounted to."
+          },
+          "mountType": {
+            "$ref": "MountType",

[zel, 2011/07/22 21:12:23]

make this string and put that enum here as :

"type": "string",
"enum": ["device", "file", "network"],

[tbarzic, 2011/07/22 22:04:48]

Done.

+            "description": "Type of the mount."
+          }
+        }
+      },
+      {
         "id": "FileWatchEvent",
         "type": "object",
         "description": "Payload data for disk mount / unmount event.",
@@ -5502,6 +5536,18 @@
         ]
       },
       {
+        "name": "onMountCompleted",
+        "type": "function",
+        "description": "Fired when mount event is detected.",
+        "parameters": [
+          {
+            "$ref": "MountCompletedEvent",
+            "name": "event",
+            "description": "MountCompleted event information."
+          }
+        ]
+      },
+      {
         "name": "onFileChanged",
         "type": "function",
         "description": "Fired when watched file change event is detected.",