Adding support for mount point different from removable devices to MountLibrary

chrome/browser/chromeos/cros/mount_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_
 #pragma once
 
+#include <map>
+#include <set>
 #include <string>
-#include <map>
 
 #include "base/memory/singleton.h"
 #include "base/observer_list.h"
 #include "base/time.h"
 #include "third_party/cros/chromeos_mount.h"
 
 namespace chromeos {
 
 typedef enum MountLibraryEventType {
   MOUNT_DISK_ADDED,
@@ skipping 69 matching lines @@
     std::string parent_path_;
     DeviceType device_type_;
     uint64 total_size_;
     bool is_parent_;
     bool is_read_only_;
     bool has_media_;
     bool on_boot_device_;
   };
   typedef std::map<std::string, Disk*> DiskMap;
 
+  typedef std::set<std::string> MountPointSet;

[zel, 2011/07/22 04:47:17]

this does not have enough information, in addition to mountPath (i hope this is
what string is here for) you should add

mountType
source

[tbarzic, 2011/07/22 06:21:51]

I know, I had in plan to add these (well, at least source) ;)

Done.

+
   typedef void(*UnmountDeviceRecursiveCallbackType)(void*, bool);
 
   class Observer {
    public:
     virtual ~Observer() {}
     // Async API events.
     virtual void DiskChanged(MountLibraryEventType event,
                              const Disk* disk) = 0;
     virtual void DeviceChanged(MountLibraryEventType event,
                                const std::string& device_path ) = 0;
+    virtual void MountCompleted(MountError error_code,
+                                const std::string& source,
+                                MountType mount_type,
+                                const std::string& mount_path) = 0;
   };
 
   virtual ~MountLibrary() {}
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
   virtual const DiskMap& disks() const = 0;
+  virtual const MountPointSet& mount_points() const = 0;
 
   virtual void RequestMountInfoRefresh() = 0;
-  virtual void MountPath(const char* device_path) = 0;
-  virtual void UnmountPath(const char* device_path) = 0;
+  virtual void MountPath(const char* source_path,
+                         MountType type,
+                         const MountPathOptions& options) = 0;
+  // |path| may be source od mount path.
+  virtual void UnmountPath(const char* path) = 0;
 
   // Unmounts device_poath and all of its known children.
   virtual void UnmountDeviceRecursive(const char* device_path,
       UnmountDeviceRecursiveCallbackType callback, void* user_data) = 0;
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via CrosLibrary::Get().
   static MountLibrary* GetImpl(bool stub);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_MOUNT_LIBRARY_H_