Apply content-security-policy to chrome://net-internals.

Apply content-security-policy to chrome://net-internals. Also get rid of yucky data: urls and serve help page from this UI source as well.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93953

[Tom Sepez, 2011-07-19 22:23:02]

Next one.

[abarth-chromium, 2011-07-19 22:32:26]

Looks plausible to me, but I'm far from the expert here.

[eroman, 2011-07-20 01:13:06]

Could you give me a brief introduction as to what content-security-policy is, or
where I can find out more information?

In the meantime I'll try to make sense of this change :)

[Evan Stade, 2011-07-20 01:23:24]

On 2011/07/20 01:13:06, eroman wrote:
> Could you give me a brief introduction as to what content-security-policy is,
or
> where I can find out more information?
> 
> In the meantime I'll try to make sense of this change :)

http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

[Evan Stade, 2011-07-20 01:36:16]

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/help.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/help.js:5:
document.addEventListener("DOMContentLoaded", function () {
always use single quotes in js

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.js:33:
document.getElementById("help-for-bug-dump").addEventListener(
$()

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.js:34: "click",
window.open.bind(window, "chrome://net-internals/help.html"));
this usage of bind is not wrong, but it seems a little roundabout, and less
clear than

function() { window.open(...); }

[eroman, 2011-07-20 01:50:34]

LGTM.

thanks for cleaning up the help too!

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.js:34: "click",
window.open.bind(window, "chrome://net-internals/help.html"));
nit: rather than adding an event listener, could probably just change the
original link to be:

<a href="chrome://net-internals/help.html" target="_blank">

http://codereview.chromium.org/7455005/diff/4001/chrome/test/functional/speci...
File chrome/test/functional/special_tabs.py (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/test/functional/speci...
chrome/test/functional/special_tabs.py:61: 'chrome://net-internals': {},
Should this have a 'title' property?

[eroman, 2011-07-20 01:52:54]

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.js:33:
document.getElementById("help-for-bug-dump").addEventListener(
On 2011/07/20 01:36:16, Evan Stade wrote:
> $()

I am pretty sure net-internals does not define $ anywhere, so I doubt that will
work...

[Tom Sepez, 2011-07-20 18:34:39]

Not present and I didn't want to burden the page with utils.js just for this one
function.

[Evan Stade, 2011-07-20 18:57:15]

On 2011/07/20 18:34:39, Tom Sepez wrote:
> Not present and I didn't want to burden the page with utils.js just for this
one
> function.

I don't think it's much of a burden, as it's a pretty short file. It's
definitely worth it for increased code readability, as document.getElementById
is used 82 times in net_internals. Since this is just a refactor I won't ask you
to fix the other 82 instances but instead of adding new ones, you could at least
start down the right path.

[Tom Sepez, 2011-07-25 16:59:13]

Okay, added the $s

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/help.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/help.js:5:
document.addEventListener("DOMContentLoaded", function () {
On 2011/07/20 01:36:16, Evan Stade wrote:
> always use single quotes in js

Done.

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/help.js:5:
document.addEventListener("DOMContentLoaded", function () {
On 2011/07/20 01:36:16, Evan Stade wrote:
> always use single quotes in js

Done.

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.js (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.js:34: "click",
window.open.bind(window, "chrome://net-internals/help.html"));
On 2011/07/20 01:50:34, eroman wrote:
> nit: rather than adding an event listener, could probably just change the
> original link to be:
> 
> <a href="chrome://net-internals/help.html" target="_blank">

Done.

http://codereview.chromium.org/7455005/diff/4001/chrome/test/functional/speci...
File chrome/test/functional/special_tabs.py (right):

http://codereview.chromium.org/7455005/diff/4001/chrome/test/functional/speci...
chrome/test/functional/special_tabs.py:61: 'chrome://net-internals': {},
On 2011/07/20 01:50:34, eroman wrote:
> Should this have a 'title' property?
Only if there is a title tag on the page itself. Otherwise, the title can be
determined from the URL.

[Tom Sepez, 2011-07-25 17:16:45]

Ok, I think I've finally got these cleaned up, please review.

[Evan Stade, 2011-07-25 17:47:00]

lgtm

[Tom Sepez, 2011-07-25 18:09:23]

pyauto_functional_tests-only bot runs:

http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/39426
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/44625