Issue 7453053: history: use display title, not page title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7453053: history: use display title, not page title (Closed)

Created:
9 years, 4 months ago by Evan Martin

Modified:
9 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

history: use display title, not page title entry.title() is the underlying page title, but we want to record in history the actual title we show to the user. These differ in corner cases like when the page lacks a title, and also importantly in that the display title can include RTL metadata. BUG=27094 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95008

Patch Set 1 #

Patch Set 2 : ok #

Patch Set 3 : const #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	chrome/browser/history/history_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/navigation_entry.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

I feel like there was a reason we didn't do this, but I can't think ...

9 years, 4 months ago (2011-08-01 21:29:08 UTC) #2

LGTM

Expand Messages | Collapse Messages