Issue 7453045: Moved ChromeOS Image Editor into an iframe.

Issue 7453045: Moved ChromeOS Image Editor into an iframe. (Closed)

Created:
9 years, 4 months ago by Vladislav Kaznacheev

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, SeRya

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), achuith+watch_chromium.org, rginda+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Moved ChromeOS Image Editor into an iframe. This gives better modularity (no need to include every js file into main.html). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95392

Patch Set 1 : Correct base version #

Patch Set 3 : Addressed comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -283 lines)			Patch
M	chrome/browser/resources/component_extension_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	2 chunks	+25 lines, -26 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.css	View		2 chunks	+6 lines, -8 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/image_editor/image_editor.html	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.js	View		2 chunks	+57 lines, -15 lines	0 comments	Download
D	chrome/browser/resources/file_manager/js/image_editor/image_editor_test.html	View		1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/browser/resources/file_manager/js/image_editor/image_editor_test.js	View		1 chunk	+0 lines, -103 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_util.js	View		1 chunk	+5 lines, -4 lines	0 comments	Download
A +	chrome/browser/resources/file_manager/js/image_editor/standalone_test.html	View	1	2 chunks	+29 lines, -22 lines	0 comments	Download
A +	chrome/browser/resources/file_manager/js/image_editor/standalone_test.js	View		3 chunks	+20 lines, -26 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi Robert, I did not like the fact that main.html includes every piece of the ...

9 years, 4 months ago (2011-08-01 16:08:18 UTC) #1

SeRya

LGTM with comments http://codereview.chromium.org/7453045/diff/2002/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/7453045/diff/2002/chrome/browser/resources/file_manager/js/file_manager.js#newcode1368 chrome/browser/resources/file_manager/js/file_manager.js:1368: FileManager.prototype.openImageEditor = function(entry) { Shouldn't it ...

9 years, 4 months ago (2011-08-02 17:53:57 UTC) #3

Vladislav Kaznacheev

Thanks for the review. Will commit as soon as the other patch comes through. http://codereview.chromium.org/7453045/diff/2002/chrome/browser/resources/file_manager/js/file_manager.js ...

9 years, 4 months ago (2011-08-03 09:46:41 UTC) #4

commit-bot: I haz the power

9 years, 4 months ago (2011-08-03 16:00:43 UTC) #5

Can't process patch for file
chrome/browser/resources/file_manager/js/image_editor/standalone_test.html.
A +

Expand Messages | Collapse Messages