Added flags to expose GCP->print preview integration

Added flags to expose GCP->print preview integration


BUG=http://code.google.com/p/chromium-os/issues/detail?id=16082 
TEST=On chrome os about:flags should contain a print preview option.  On all other platforms about:flags should contain a cloud print option.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97982

[Albert Bodenhamer, 2011-08-22 23:09:38]

Merged with latest changes.  Please take a look when you have a chance.

[Scott Byer, 2011-08-22 23:35:50]

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:163: #if !defined(GOOGLE_CHROME_BUILD) ||
defined(OS_CHROMEOS)
There's a subtlety here with about flags and sync services - if the flag isn't
always present, it gets stripped from the flags to be set, leading to possible
strange behavior for users of multiple machines.

See the flag enablement for cloud-print-proxy - essentially zeroing out the OS
flag under the right cases keeps the flag  setting across platforms but doesn't
expose it.

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:169: IDS_FLAGS_CLOUD_PRINT_NAME,
Are the IDS usages backwards between the two flags?

[Albert Bodenhamer, 2011-08-23 01:05:07]

Is there a good way to test this for chrome OS without creating a full image in
a VM?  If I try to open about:flags in a chromium for chrome os build on Linux I
just get told I'm not the machine owner.

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:163: #if !defined(GOOGLE_CHROME_BUILD) ||
defined(OS_CHROMEOS)
On 2011/08/22 23:35:50, Scott Byer wrote:
> There's a subtlety here with about flags and sync services - if the flag isn't
> always present, it gets stripped from the flags to be set, leading to possible
> strange behavior for users of multiple machines.
> 
> See the flag enablement for cloud-print-proxy - essentially zeroing out the OS
> flag under the right cases keeps the flag  setting across platforms but
doesn't
> expose it.

Done.

http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:169: IDS_FLAGS_CLOUD_PRINT_NAME,
On 2011/08/22 23:35:50, Scott Byer wrote:
> Are the IDS usages backwards between the two flags?
Yikes!  Good catch.  A different logic error was masking the effects of this in
my testing.

[Scott Byer, 2011-08-23 22:25:00]

LGTM, just double check the flags you think should come up in CrOS come up:

Modify chrome/browser/ui/webui/flags_ui.cc temporarily to skip the owners check.


On 2011/08/23 01:05:07, Albert Bodenhamer wrote:
> Is there a good way to test this for chrome OS without creating a full image
in
> a VM?  If I try to open about:flags in a chromium for chrome os build on Linux
I
> just get told I'm not the machine owner.
> 
> http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.cc
> File chrome/browser/about_flags.cc (right):
> 
>
http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
> chrome/browser/about_flags.cc:163: #if !defined(GOOGLE_CHROME_BUILD) ||
> defined(OS_CHROMEOS)
> On 2011/08/22 23:35:50, Scott Byer wrote:
> > There's a subtlety here with about flags and sync services - if the flag
isn't
> > always present, it gets stripped from the flags to be set, leading to
possible
> > strange behavior for users of multiple machines.
> > 
> > See the flag enablement for cloud-print-proxy - essentially zeroing out the
OS
> > flag under the right cases keeps the flag  setting across platforms but
> doesn't
> > expose it.
> 
> Done.
> 
>
http://codereview.chromium.org/7453036/diff/7001/chrome/browser/about_flags.c...
> chrome/browser/about_flags.cc:169: IDS_FLAGS_CLOUD_PRINT_NAME,
> On 2011/08/22 23:35:50, Scott Byer wrote:
> > Are the IDS usages backwards between the two flags?
> Yikes!  Good catch.  A different logic error was masking the effects of this
in
> my testing.

[commit-bot: I haz the power, 2011-08-24 03:31:22]

Change committed as 97982