[Sync] Refactor sync datatype error handling.

chrome/browser/sync/syncable/model_type.cc

Index: chrome/browser/sync/syncable/model_type.cc
diff --git a/chrome/browser/sync/syncable/model_type.cc b/chrome/browser/sync/syncable/model_type.cc
index 868b43caea1e868ace627f3ceff37aeee0e0e01f..7749f65581558aaa98b4abc2afe2d771955a8e88 100644
--- a/chrome/browser/sync/syncable/model_type.cc
+++ b/chrome/browser/sync/syncable/model_type.cc
@@ -247,7 +247,10 @@ std::string ModelTypeSetToString(const ModelTypeSet& model_types) {
   std::string result;
   for (ModelTypeSet::const_iterator iter = model_types.begin();
        iter != model_types.end();) {
-    result += ModelTypeToString(*iter);
+    if (*iter >= FIRST_REAL_MODEL_TYPE && *iter < MODEL_TYPE_COUNT)

[akalin, 2011/07/20 23:43:59]

Hmm.  What is the reason for this?

[Nicolas Zea, 2011/07/21 20:09:50]

Yeah, thinking about it more this isn't the right approach. Done.

+      result += ModelTypeToString(*iter);
+    else
+      result += "Unspecified";
     if (++iter != model_types.end())
       result += ", ";
   }