chrome/browser/sync/glue/typed_url_model_associator.h - Issue 7453014: [Sync] Refactor sync datatype error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_model_associator.h

Issue 7453014: [Sync] Refactor sync datatype error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and fix final unit test <3 c++ Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/typed_url_model_associator.h

diff --git a/chrome/browser/sync/glue/typed_url_model_associator.h b/chrome/browser/sync/glue/typed_url_model_associator.h

index fb75550ff131db4dd58b3e8206f47c2d5f2c5484..ae4c5c180ae852625047727676f8e4f10132f2e1 100644

--- a/chrome/browser/sync/glue/typed_url_model_associator.h

+++ b/chrome/browser/sync/glue/typed_url_model_associator.h

@@ -61,13 +61,13 @@ class TypedUrlModelAssociator

// PerDataTypeAssociatorInterface implementation.

// Iterates through the sync model looking for matched pairs of items.

- virtual bool AssociateModels();

+ virtual bool AssociateModels(SyncError* error);

// Delete all typed url nodes.

bool DeleteAllNodes(sync_api::WriteTransaction* trans);

// Clears all associations.

- virtual bool DisassociateModels();

+ virtual bool DisassociateModels(SyncError* error);

// The has_nodes out param is true if the sync model has nodes other

// than the permanent tagged nodes.