Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/sync/api/sync_change_processor.h

Issue 7453014: [Sync] Refactor sync datatype error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Really fix compile Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/api/sync_change_processor.h
diff --git a/chrome/browser/sync/api/sync_change_processor.h b/chrome/browser/sync/api/sync_change_processor.h
index 80be610ab5b4902bf0e1f6021108af4f1f38f2e2..ec3e8d3ac36386adc0f0f73e9322a5d1c034a05c 100644
--- a/chrome/browser/sync/api/sync_change_processor.h
+++ b/chrome/browser/sync/api/sync_change_processor.h
@@ -9,6 +9,7 @@
#include <vector>
class SyncChange;
+class SyncError;
namespace tracked_objects {
class Location;
@@ -20,8 +21,14 @@ typedef std::vector<SyncChange> SyncChangeList;
class SyncChangeProcessor {
public:
// Process a list of SyncChanges.
- virtual void ProcessSyncChanges(const tracked_objects::Location& from_here,
- const SyncChangeList& change_list) = 0;
+ // Returns: False if an error occured, true otherwise.
+ // Inputs:
+ // |from_here|: allows tracking of where sync changes originate.
+ // |change_list|: is the list of sync changes in need of processing.
+ // |error|: if an error occurred, the error tracking information.
+ virtual bool ProcessSyncChanges(const tracked_objects::Location& from_here,
+ const SyncChangeList& change_list,
+ SyncError* error) = 0;
protected:
virtual ~SyncChangeProcessor();
};

Powered by Google App Engine
This is Rietveld 408576698