Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/browser/sync/glue/syncable_service_adapter.cc

Issue 7453014: [Sync] Refactor sync datatype error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add operator= Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/syncable_service_adapter.cc
diff --git a/chrome/browser/sync/glue/syncable_service_adapter.cc b/chrome/browser/sync/glue/syncable_service_adapter.cc
index 68dcfae9b0f69880a1cbb7259a0f2de7cb5f56d2..bacc0a3e88bb23521bd2eefdf40002cc02429a6a 100644
--- a/chrome/browser/sync/glue/syncable_service_adapter.cc
+++ b/chrome/browser/sync/glue/syncable_service_adapter.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/sync/glue/syncable_service_adapter.h"
+#include "chrome/browser/sync/api/sync_error.h"
#include "chrome/browser/sync/api/syncable_service.h"
#include "chrome/browser/sync/api/sync_data.h"
#include "chrome/browser/sync/glue/generic_change_processor.h"
@@ -30,18 +31,22 @@ SyncableServiceAdapter::~SyncableServiceAdapter() {
}
}
-bool SyncableServiceAdapter::AssociateModels() {
+bool SyncableServiceAdapter::AssociateModels(SyncError* error) {
syncing_ = true;
SyncDataList initial_sync_data;
- if (!sync_processor_->GetSyncDataForType(type_, &initial_sync_data)) {
+ if (!sync_processor_->GetSyncDataForType(type_,
+ &initial_sync_data,
+ error)) {
return false;
}
+ DCHECK(!error->IsInitialized());
return service_->MergeDataAndStartSyncing(type_,
initial_sync_data,
- sync_processor_);
+ sync_processor_,
+ error);
}
-bool SyncableServiceAdapter::DisassociateModels() {
+bool SyncableServiceAdapter::DisassociateModels(SyncError* error) {
service_->StopSyncing(type_);
syncing_ = false;
return true;

Powered by Google App Engine
This is Rietveld 408576698