[Sync] Refactor sync datatype error handling.

chrome/browser/sync/api/sync_error.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync/api/sync_error.h"
+
+#include "base/logging.h"
+
+SyncError::SyncError() {
+}
+
+SyncError::SyncError(const tracked_objects::Location& location,
+                     const std::string& message,
+                     syncable::ModelType type)
+    : location_(new tracked_objects::Location(location)),
+      message_(message),
+      type_(type) {
+  print_log_error();
+}
+
+SyncError::SyncError(const SyncError& rhs) {
+  location_.reset(new tracked_objects::Location(rhs.location()));
+  message_ = rhs.message();
+  type_ = rhs.type();
+}
+
+void SyncError::Reset(const tracked_objects::Location& location,
+                      const std::string& message,
+                      syncable::ModelType type) {
+  location_.reset(new tracked_objects::Location(location));
+  message_ = message;
+  type_ = type;
+  print_log_error();
+}
+
+bool SyncError::IsInitialized() const {
+  return location_.get() != NULL;
+}
+
+const tracked_objects::Location& SyncError::location() const {
+  CHECK(IsInitialized());
+  return *location_;
+}
+
+const std::string& SyncError::message() const {
+  DCHECK(IsInitialized());

[akalin, 2011/07/21 23:03:53]

should probably be a CHECK, too, for consistency

[Nicolas Zea, 2011/07/21 23:43:26]

Done.

+  return message_;
+}
+
+const syncable::ModelType SyncError::type() const {
+  DCHECK(IsInitialized());

[akalin, 2011/07/21 23:03:53]

here too

[Nicolas Zea, 2011/07/21 23:43:26]

Done.

+  return type_;
+}
+
+void SyncError::print_log_error() const {
+  LAZY_STREAM(logging::LogMessage(location_->file_name(),
+                                  location_->line_number(),
+                                  ERROR).stream(),

[akalin, 2011/07/21 23:03:53]

how does this work?  I think you need to do logging::LOG_ERROR instead of ERROR.
 Maybe ERROR is defined in some system header.  Ugh.

[Nicolas Zea, 2011/07/21 23:43:26]

ERROR is a macro from logging.h that turns into 0. And apparently
logging::LOG_INFO is an enum that turns into 0. So I was sending the wrong
severity. Sneaky.

+              LOG_IS_ON(ERROR))
+      << syncable::ModelTypeToString(type_) << " Sync Error: " << message_;
+}