[Sync] Refactor sync datatype error handling.

chrome/browser/prefs/pref_model_associator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_
 #define CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_
 #pragma once
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/threading/non_thread_safe.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/sync/api/syncable_service.h"
 #include "chrome/browser/sync/api/sync_data.h"
+#include "chrome/browser/sync/api/sync_error.h"

[akalin, 2011/07/21 23:03:53]

forward declare instead?  Or just not #include, since it's part of the inherited
interface

[Nicolas Zea, 2011/07/21 23:43:27]

Done.

 
 namespace sync_pb {
 class PreferenceSpecifics;
 }
 
 namespace base {
 class Value;
 }
 
 // Contains all preference sync related logic.
 // TODO(sync): Merge this into PrefService once we separate the profile
 // PrefService from the local state PrefService.
 class PrefModelAssociator
     : public SyncableService,
       public base::NonThreadSafe {
  public:
   explicit PrefModelAssociator(PrefService* pref_service);
   virtual ~PrefModelAssociator();
 
   // SyncableService implementation.
   virtual SyncDataList GetAllSyncData(syncable::ModelType type) const OVERRIDE;
-  virtual void ProcessSyncChanges(const tracked_objects::Location& from_here,
-                                  const SyncChangeList& change_list) OVERRIDE;
+  virtual bool ProcessSyncChanges(const tracked_objects::Location& from_here,
+                                  const SyncChangeList& change_list,
+                                  SyncError* error) OVERRIDE;
   virtual bool MergeDataAndStartSyncing(
       syncable::ModelType type,
       const SyncDataList& initial_sync_data,
-      SyncChangeProcessor* sync_processor) OVERRIDE;
+      SyncChangeProcessor* sync_processor,
+      SyncError* error) OVERRIDE;
   virtual void StopSyncing(syncable::ModelType type) OVERRIDE;
 
   // Returns the list of preference names that are registered as syncable, and
   // hence should be monitored for changes.
   std::set<std::string> registered_preferences() const;
 
   // Register a preference with the specified name for syncing. We do not care
   // about the type at registration time, but when changes arrive from the
   // syncer, we check if they can be applied and if not drop them.
   // Note: This should only be called at profile startup time (before sync
@@ skipping 84 matching lines @@
   // The PrefService we are syncing to.
   PrefService* pref_service_;
 
   // Sync's SyncChange handler. We push all our changes through this.
   SyncChangeProcessor* sync_processor_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefModelAssociator);
 };
 
 #endif  // CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_