Change Chromoting client to use Pepper's new Resource-base InputEvents.

remoting/client/plugin/pepper_view.h

Index: remoting/client/plugin/pepper_view.h
diff --git a/remoting/client/plugin/pepper_view.h b/remoting/client/plugin/pepper_view.h
index e869d915e07dcde308b73b1b88602f5f6d33a5ad..3e2f8a871c74ec9a972ba6563e40dd822f43af74 100644
--- a/remoting/client/plugin/pepper_view.h
+++ b/remoting/client/plugin/pepper_view.h
@@ -14,6 +14,7 @@
 #include "base/task.h"
 #include "media/base/video_frame.h"
 #include "ppapi/cpp/graphics_2d.h"
+#include "ppapi/cpp/point.h"
 #include "remoting/client/chromoting_view.h"
 #include "remoting/client/frame_consumer.h"
 
@@ -40,7 +41,6 @@ class PepperView : public ChromotingView,
   virtual void UpdateLoginStatus(bool success, const std::string& info)
       OVERRIDE;
   virtual void SetViewport(int x, int y, int width, int height) OVERRIDE;
-  virtual gfx::Point ConvertScreenToHost(const gfx::Point& p) const OVERRIDE;
 
   // FrameConsumer implementation.
   virtual void AllocateFrame(media::VideoFrame::Format format,
@@ -55,6 +55,10 @@ class PepperView : public ChromotingView,
                                     UpdatedRects* rects,
                                     Task* done);
 
+  // Converts screen co-ordinates to host co-ordinates, and clips to the host
+  // screen.

[Wez, 2011/07/20 00:58:35]

"and clips to the host screen" doesn't sound right.  The Host needs to cope with
mouse coordinates outside its dimensions, since it may be resized asynchronously
to client mouse movement.  What is the purpose of clipping here?

[garykac, 2011/07/20 18:55:28]

!ExpandingScopeAlert!

We should follow up with Simon re: this because the comment (copied from
chromoting_view.h) is correct - it does clip to the host width/height.

And I agree that it doesn't seem like it should need to be clipping to the host.

[simonmorris, 2011/07/20 19:12:32]

I think I remember adding the "clip to host" for
scale-to-fit. Without it, the host (a Mac, I think)
could lose the cursor entirely if the client cursor
moved outside the view of the host screen.

Maybe that's been fixed now, but I agree it ought to be.
Probably in another CL.

+  pp::Point ConvertScreenToHost(const pp::Point& p) const;
+
   // Sets the size of the visible screen area that this object can render into.
   void SetScreenSize(int width, int height);
 
@@ -68,13 +72,13 @@ class PepperView : public ChromotingView,
 
   // Blits the pixels in |r| in the backing store into the corresponding
   // rectangle in the scaled backing store. Returns that rectangle.
-  gfx::Rect UpdateScaledBackingStore(const gfx::Rect& r);
+  pp::Rect UpdateScaledBackingStore(const pp::Rect& r);
 
   // Blanks out a rectangle in an image.
-  void BlankRect(pp::ImageData& image_data, const gfx::Rect& rect);
+  void BlankRect(pp::ImageData& image_data, const pp::Rect& rect);
 
   // Converts host co-ordinates to screen co-ordinates.
-  gfx::Point ConvertHostToScreen(const gfx::Point& p) const;
+  pp::Point ConvertHostToScreen(const pp::Point& p) const;

[Wez, 2011/07/20 00:58:35]

nit: Naming.

[garykac, 2011/07/20 18:55:28]

see previous comment re: screen.

 
   // Sets the screen scale. A value of 1.0 indicates no scaling.
   void SetScreenScale(double screen_scale);