Chromium Code Reviews| Index: remoting/client/plugin/chromoting_instance.cc |
| diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc |
| index e25364102ebafc6c50dcf302adac3f59bfcb631a..d29352590e9fb7def7fb600a62020b7deb4d61e7 100644 |
| --- a/remoting/client/plugin/chromoting_instance.cc |
| +++ b/remoting/client/plugin/chromoting_instance.cc |
| @@ -19,8 +19,8 @@ |
| // crbug.com/74951 |
| #include "content/renderer/p2p/ipc_network_manager.h" |
| #include "content/renderer/p2p/ipc_socket_factory.h" |
| -#include "ppapi/c/pp_input_event.h" |
| #include "ppapi/cpp/completion_callback.h" |
| +#include "ppapi/cpp/input_event.h" |
| #include "ppapi/cpp/rect.h" |
| // TODO(wez): Remove this when crbug.com/86353 is complete. |
| #include "ppapi/cpp/private/var_private.h" |
| @@ -55,6 +55,8 @@ ChromotingInstance::ChromotingInstance(PP_Instance pp_instance) |
| : pp::InstancePrivate(pp_instance), |
| initialized_(false), |
| logger_(this) { |
| + RequestInputEvents(PP_INPUTEVENT_CLASS_MOUSE | PP_INPUTEVENT_CLASS_WHEEL); |
| + RequestFilteringInputEvents(PP_INPUTEVENT_CLASS_KEYBOARD); |
| } |
| ChromotingInstance::~ChromotingInstance() { |
| @@ -169,25 +171,25 @@ void ChromotingInstance::DidChangeView(const pp::Rect& position, |
| view_->SetScreenSize(clip.width(), clip.height()); |
| } |
| -bool ChromotingInstance::HandleInputEvent(const PP_InputEvent& event) { |
| +bool ChromotingInstance::HandleInputEvent(const pp::InputEvent& event) { |
| DCHECK(CurrentlyOnPluginThread()); |
| PepperInputHandler* pih |
| = static_cast<PepperInputHandler*>(input_handler_.get()); |
| - switch (event.type) { |
| + switch (event.GetType()) { |
| case PP_INPUTEVENT_TYPE_MOUSEDOWN: |
| - pih->HandleMouseButtonEvent(true, event.u.mouse); |
| + pih->HandleMouseButtonEvent(true, pp::MouseInputEvent(event)); |
| return true; |
| case PP_INPUTEVENT_TYPE_MOUSEUP: |
| - pih->HandleMouseButtonEvent(false, event.u.mouse); |
| + pih->HandleMouseButtonEvent(false, pp::MouseInputEvent(event)); |
| return true; |
| case PP_INPUTEVENT_TYPE_MOUSEMOVE: |
| case PP_INPUTEVENT_TYPE_MOUSEENTER: |
| case PP_INPUTEVENT_TYPE_MOUSELEAVE: |
| - pih->HandleMouseMoveEvent(event.u.mouse); |
| + pih->HandleMouseMoveEvent(pp::MouseInputEvent(event)); |
| return true; |
| case PP_INPUTEVENT_TYPE_CONTEXTMENU: |
| @@ -197,18 +199,21 @@ bool ChromotingInstance::HandleInputEvent(const PP_InputEvent& event) { |
| case PP_INPUTEVENT_TYPE_KEYDOWN: |
| case PP_INPUTEVENT_TYPE_KEYUP: |
| - logger_.VLog(3, "PP_INPUTEVENT_TYPE_KEY%s key=%d", |
| - (event.type==PP_INPUTEVENT_TYPE_KEYDOWN ? "DOWN" : "UP"), |
| - event.u.key.key_code); |
| - pih->HandleKeyEvent(event.type == PP_INPUTEVENT_TYPE_KEYDOWN, |
| - event.u.key); |
| - return true; |
| + { |
| + pp::KeyboardInputEvent key = pp::KeyboardInputEvent(event); |
| + logger_.VLog(3, "PP_INPUTEVENT_TYPE_KEY%s key=%d", |
| + (event.GetType()==PP_INPUTEVENT_TYPE_KEYDOWN ? "DOWN" : "UP"), |
|
dmac
2011/07/20 00:34:31
space between ) and ==
garykac
2011/07/20 18:55:28
Done.
|
| + key.GetKeyCode()); |
| + pih->HandleKeyEvent(event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN, key); |
|
Wez
2011/07/20 00:58:35
nit: Why use event.GetType() == foo here, but not
garykac
2011/07/20 18:55:28
made consistent
|
| + return true; |
| + } |
| case PP_INPUTEVENT_TYPE_CHAR: |
| - pih->HandleCharacterEvent(event.u.character); |
| + pih->HandleCharacterEvent(pp::KeyboardInputEvent(event)); |
| return true; |
| default: |
| + LOG(INFO) << "Unhandled input event: " << event.GetType(); |
| break; |
| } |