Issue 7452020: Preparing push to trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7452020: Preparing push to trunk. (Closed)

Created:
9 years, 5 months ago by rossberg

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Preparing push to trunk. Committed: http://code.google.com/p/v8/source/detail?r=8695

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	ChangeLog	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, I would remove anything that is not directly useful for embedders from the ChangeLog ...

9 years, 5 months ago (2011-07-20 13:06:04 UTC) #2

rossberg

9 years, 5 months ago (2011-07-20 13:17:01 UTC) #3

http://codereview.chromium.org/7452020/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7452020/diff/1/ChangeLog#newcode3
ChangeLog:3: Implement sealing, freezing, and related functions for proxies.
On 2011/07/20 13:06:04, Mads Ager wrote:
> I would not put any proxy stuff in the ChangeLog since it is not turned on by
> default.

Done.

http://codereview.chromium.org/7452020/diff/1/ChangeLog#newcode9
ChangeLog:9: Implement setting the length property for FixedDoubleArrays.
On 2011/07/20 13:06:04, Mads Ager wrote:
> I would put double array stuff in here either.

Done.

http://codereview.chromium.org/7452020/diff/1/ChangeLog#newcode15
ChangeLog:15: grokdump: Add simple support for non-full minudumps.
On 2011/07/20 13:06:04, Mads Ager wrote:
> Internal tool, remove.

Done.

Expand Messages | Collapse Messages