Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2207)

Unified Diff: chrome/browser/ui/webui/extension_icon_source.cc

Issue 7452008: Improve layout for bookmark-apps. Add a treatment for small icons. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Submit-ready Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extension_icon_source.cc
diff --git a/chrome/browser/ui/webui/extension_icon_source.cc b/chrome/browser/ui/webui/extension_icon_source.cc
index 78c7b27b8f8889f3e86cccd4b6de25549d54f9bf..6a52ba6540d1c06e025e6466d92c9f8cf2a823cd 100644
--- a/chrome/browser/ui/webui/extension_icon_source.cc
+++ b/chrome/browser/ui/webui/extension_icon_source.cc
@@ -75,10 +75,16 @@ ExtensionIconSource::~ExtensionIconSource() {
GURL ExtensionIconSource::GetIconURL(const Extension* extension,
Extension::Icons icon_size,
ExtensionIconSet::MatchType match,
- bool grayscale) {
+ bool grayscale,
+ bool* exists) {
+ if (exists)
+ *exists = true;
if (extension->id() == extension_misc::kWebStoreAppId)
return GURL("chrome://theme/IDR_WEBSTORE_ICON");
+ if (exists && extension->GetIconURL(icon_size, match) == GURL())
+ *exists = false;
+
GURL icon_url(base::StringPrintf("%s%s/%d/%d%s",
chrome::kChromeUIExtensionIconURL,
extension->id().c_str(),
« no previous file with comments | « chrome/browser/ui/webui/extension_icon_source.h ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698