Issue 7452002: Remove HandleInputEvent from PPP_Instance and freeze to 1.0.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -289 lines)			Patch
M	ppapi/api/ppp_instance.idl	View		3 chunks	+8 lines, -37 lines	0 comments	Download
M	ppapi/c/pp_input_event.h	View	1	1 chunk	+0 lines, -38 lines	0 comments	Download
M	ppapi/c/ppp_instance.h	View		4 chunks	+10 lines, -35 lines	0 comments	Download
M	ppapi/cpp/instance.h	View	1 2 3 4	1 chunk	+1 line, -4 lines	0 comments	Download
M	ppapi/cpp/instance.cc	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ppapi/cpp/module.cc	View		2 chunks	+0 lines, -12 lines	0 comments	Download
M	ppapi/examples/2d/graphics_2d_example.c	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
M	ppapi/examples/2d/paint_manager_example.cc	View	1 2 3 4 5	2 chunks	+12 lines, -10 lines	0 comments	Download
M	ppapi/examples/file_chooser/file_chooser.cc	View	1 2 3 4 5 6	3 chunks	+9 lines, -6 lines	0 comments	Download
M	ppapi/proxy/dispatcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppapi_param_traits.h	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppapi_param_traits.cc	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_proxy.h	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_proxy.cc	View	1	5 chunks	+5 lines, -29 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_proxy_test.cc	View	1	4 chunks	+6 lines, -29 lines	0 comments	Download
M	ppapi/shared_impl/ppp_instance_combined.h	View	1	1 chunk	+41 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/ppp_instance_combined.cc	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/event_conversion.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2 3 4 5	2 chunks	+8 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1 2 3 4 5	11 chunks	+39 lines, -23 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_unittest.cc	View	1 2	3 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_tracker_unittest.cc	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

The trybots are not available. It should be very close to right, though, so PTAL.

9 years, 5 months ago (2011-07-19 22:09:25 UTC) #1

dmichael (off chromium)

On 2011/07/19 22:09:25, dmichael wrote: > The trybots are not available. It should be very ...

9 years, 5 months ago (2011-07-19 22:11:20 UTC) #2

dmichael (off chromium)

On 2011/07/19 22:11:20, dmichael wrote: > On 2011/07/19 22:09:25, dmichael wrote: > > The trybots ...

9 years, 5 months ago (2011-07-20 04:14:07 UTC) #3

brettw

9 years, 5 months ago (2011-07-20 04:18:48 UTC) #4

LGTM. This 1.0 thing has a nice ring!

http://codereview.chromium.org/7452002/diff/9025/ppapi/examples/2d/paint_mana...
File ppapi/examples/2d/paint_manager_example.cc (right):

http://codereview.chromium.org/7452002/diff/9025/ppapi/examples/2d/paint_mana...
ppapi/examples/2d/paint_manager_example.cc:45:
RequestFilteringInputEvents(PP_INPUTEVENT_CLASS_MOUSE);
Can you remove "Filtering" here? I'd like to encourage people to do mouse events
in non-filtered mode.

http://codereview.chromium.org/7452002/diff/9025/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/7452002/diff/9025/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:492: rv |= PPBoolToBool(
This should be PP_ToBool now.

Expand Messages | Collapse Messages