Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 7448011: Initialized variables passed to GL functions. Command buffer now only allows initialized variable... (Closed)

Created:
9 years, 5 months ago by alokp
Modified:
9 years, 5 months ago
Reviewers:
greggman
CC:
chromium-reviews
Visibility:
Public.

Description

Initialized variables passed to GL functions. Command buffer now only allows initialized variables unless it is compiled for native-client. We would need to exclude pepper plugins too. For now I have initialized the gpu demo variables. TBR=gman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/gles2_book/Chapter_11/Stencil_Test/Stencil_Test.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gles2_book/Common/Source/esShader.c View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/gles2_book/README.chromium View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alokp
9 years, 5 months ago (2011-07-19 20:22:44 UTC) #1
greggman
LGTM if you know a way to turn this off for Pepper but not for ...
9 years, 5 months ago (2011-07-20 02:02:19 UTC) #2
alokp
9 years, 5 months ago (2011-07-20 19:52:44 UTC) #3
On 2011/07/20 02:02:19, greggman wrote:
> LGTM
> 
> if you know a way to turn this off for Pepper but not for Chrome that would be
> great.

If the asserts for uninitialized variables is debug-only, I do not think it is
too important to disable them for Pepper. But if they are we need to disable
them.

Powered by Google App Engine
This is Rietveld 408576698