Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 7448005: Missing changes for IDL (Closed)

Created:
9 years, 5 months ago by noelallen1
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Missing changes for IDL To minor changes to comments for the IDL. Updated pp_stdint.idl so that we could generate it instead of checking in pp_stdint.h. In addition it now provides a location for defining built in types. Eventually we can migrate type properties into this file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93125

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M ppapi/api/pp_stdint.idl View 1 2 3 4 5 1 chunk +40 lines, -1 line 0 comments Download
M ppapi/api/trusted/ppb_file_io_trusted.idl View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M ppapi/c/pp_stdint.h View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M ppapi/c/ppb_core.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
9 years, 5 months ago (2011-07-19 17:22:32 UTC) #1
dmichael (off chromium)
LGTM http://codereview.chromium.org/7448005/diff/1/ppapi/api/pp_stdint.idl File ppapi/api/pp_stdint.idl (right): http://codereview.chromium.org/7448005/diff/1/ppapi/api/pp_stdint.idl#newcode34 ppapi/api/pp_stdint.idl:34: void; What are these ones from double_t->void for? ...
9 years, 5 months ago (2011-07-19 17:49:01 UTC) #2
noelallen1
Done. Thanks. http://codereview.chromium.org/7448005/diff/1/ppapi/api/pp_stdint.idl File ppapi/api/pp_stdint.idl (right): http://codereview.chromium.org/7448005/diff/1/ppapi/api/pp_stdint.idl#newcode34 ppapi/api/pp_stdint.idl:34: void; On 2011/07/19 17:49:01, dmichael wrote: > ...
9 years, 5 months ago (2011-07-19 20:35:23 UTC) #3
dmichael (off chromium)
On 2011/07/19 20:35:23, noelallen1 wrote: > Done. Thanks. > > http://codereview.chromium.org/7448005/diff/1/ppapi/api/pp_stdint.idl > File ppapi/api/pp_stdint.idl (right): ...
9 years, 5 months ago (2011-07-19 22:10:38 UTC) #4
noelallen1
9 years, 5 months ago (2011-07-19 22:21:55 UTC) #5
dmichael (off chromium)
9 years, 5 months ago (2011-07-19 22:23:14 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698