Deprecate Profile::GetDefaultRequestContext().

Deprecate Profile::GetDefaultRequestContext().

Make it private and establish a friend whitelist for existing users.

BUG=64339
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93200

[willchan no longer on Chromium, 2011-07-19 15:28:30]

Hey Miranda, let me know what you think of this. I noticed a few new uses have
been introduced, so I wanted to lock this down. If you're cool with this, I will
add the necessary OWNERS for approval.

[Miranda Callahan, 2011-07-19 15:37:23]

On 2011/07/19 15:28:30, willchan wrote:
> Hey Miranda, let me know what you think of this. I noticed a few new uses have
> been introduced, so I wanted to lock this down. If you're cool with this, I
will
> add the necessary OWNERS for approval.

This is great -- I was just discussing the problem of GetDefaultRequestContext
with Avi yesterday. Thanks for this!

[Miranda Callahan, 2011-07-19 15:37:43]

On 2011/07/19 15:37:23, Miranda Callahan wrote:
> On 2011/07/19 15:28:30, willchan wrote:
> > Hey Miranda, let me know what you think of this. I noticed a few new uses
have
> > been introduced, so I wanted to lock this down. If you're cool with this, I
> will
> > add the necessary OWNERS for approval.
> 
> This is great -- I was just discussing the problem of GetDefaultRequestContext
> with Avi yesterday. Thanks for this!

(Oh, and LGTM. :-)

[willchan no longer on Chromium, 2011-07-19 15:41:45]

+jam/brettw: content/ rubberstamp please :)
+estade/arv: webui/ rubberstamp please :)

[brettw, 2011-07-19 15:53:33]

Content LGTM. In the future, please just pick your favorite owner rather than
adding everybody to cut down on extra email.

[Nikita (slow), 2011-07-20 13:55:16]

chromeos/login LGTM with a question.

http://codereview.chromium.org/7438002/diff/6001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7438002/diff/6001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:84: class
ResetDefaultProxyConfigServiceTask : public Task {
Why move ResetDefaultProxyConfigServiceTask out of namespace?

[willchan no longer on Chromium, 2011-07-20 13:59:06]

http://codereview.chromium.org/7438002/diff/6001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/7438002/diff/6001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:84: class
ResetDefaultProxyConfigServiceTask : public Task {
On 2011/07/20 13:55:17, Nikita Kostylev wrote:
> Why move ResetDefaultProxyConfigServiceTask out of namespace?

Since I locked it down with a friend declaration whitelist, everything that uses
it must be publicly visible.

[commit-bot: I haz the power, 2011-07-20 15:48:56]

Change committed as 93200