Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 7438001: Cleanup: Make quota dispatcher code independent from WebKit types (Closed)

Created:
9 years, 5 months ago by kinuko
Modified:
9 years, 4 months ago
Reviewers:
michaeln, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam
Visibility:
Public.

Description

Cleanup: Make quota dispatcher code independent from WebKit types Preparing for pepper quota support. Also adding NotifyStorageModified IPC method, which is intended to be used by pepper FileIO code. BUG=for 86556 TEST=existing tests should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94638

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : removed web_quota_dispatcher_callback #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : fix #

Patch Set 5 : clang fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -76 lines) Patch
M content/browser/renderer_host/quota_dispatcher_host.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/quota_dispatcher_host.cc View 1 2 5 chunks +10 lines, -27 lines 0 comments Download
M content/common/quota_dispatcher.h View 1 2 3 4 4 chunks +20 lines, -10 lines 0 comments Download
M content/common/quota_dispatcher.cc View 1 2 3 4 chunks +70 lines, -24 lines 0 comments Download
M content/common/quota_messages.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/render_view.cc View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/quota/quota_types.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
http://codereview.chromium.org/7438001/diff/13/content/common/web_quota_dispatcher_callback.h File content/common/web_quota_dispatcher_callback.h (right): http://codereview.chromium.org/7438001/diff/13/content/common/web_quota_dispatcher_callback.h#newcode15 content/common/web_quota_dispatcher_callback.h:15: class WebQuotaDispatcherCallback : public QuotaDispatcher::Callback { This class name ...
9 years, 5 months ago (2011-07-19 20:27:36 UTC) #1
kinuko
Thanks for reviewing. I dropped web_quota_dispatcher_callback.{cc,h}, moved the impl in quota_dispatcher.cc as a hidden class ...
9 years, 5 months ago (2011-07-20 07:55:52 UTC) #2
michaeln
LGTM
9 years, 5 months ago (2011-07-20 18:04:30 UTC) #3
kinuko
jam, for content/ changes could you review this?
9 years, 5 months ago (2011-07-25 17:25:00 UTC) #4
kinuko
brettw, could you give me a LGTM for content/ changes? (Basically just a cleanup; necessary ...
9 years, 5 months ago (2011-07-27 09:20:23 UTC) #5
brettw
LGTM, just a few style nits. http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispatcher.cc File content/common/quota_dispatcher.cc (right): http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispatcher.cc#newcode21 content/common/quota_dispatcher.cc:21: namespace { Blank ...
9 years, 5 months ago (2011-07-27 15:32:08 UTC) #6
kinuko
Thanks, fixed them. Will be committing... On 2011/07/27 15:32:08, brettw wrote: > LGTM, just a ...
9 years, 4 months ago (2011-07-28 13:20:56 UTC) #7
kinuko
9 years, 4 months ago (2011-07-28 13:21:32 UTC) #8
http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispat...
File content/common/quota_dispatcher.cc (right):

http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispat...
content/common/quota_dispatcher.cc:21: namespace {
On 2011/07/27 15:32:08, brettw wrote:
> Blank line after this.

Done.

http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispat...
content/common/quota_dispatcher.cc:26: : callbacks_(c) {
On 2011/07/27 15:32:08, brettw wrote:
> Two more spaces before the :

Done.

http://codereview.chromium.org/7438001/diff/14001/content/common/quota_dispat...
content/common/quota_dispatcher.cc:44: }  // anonymous namespace
On 2011/07/27 15:32:08, brettw wrote:
> Bank line before this, no "anonymous"

Done.

Powered by Google App Engine
This is Rietveld 408576698