Issue 7436004: Implement Object.prototype.{hasOwnProperty, propertyIsEnumerable} for proxies.

Issue 7436004: Implement Object.prototype.{hasOwnProperty, propertyIsEnumerable} for proxies. (Closed)

Created:
9 years, 5 months ago by rossberg

Modified:
9 years, 5 months ago

Reviewers:
Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Implement Object.prototype.{hasOwnProperty, propertyIsEnumerable} for proxies. Refactor trap invocation. Test other Object.prototype functionality for proxies. R=ager@chromium.org BUG=v8:1543 TEST= Committed: http://code.google.com/p/v8/source/detail?r=8707

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed Mads' comments. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -40 lines)			Patch
M	src/messages.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/proxy.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	1	10 chunks	+50 lines, -37 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View	1	20 chunks	+214 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/7436004/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/7436004/diff/1/src/v8natives.js#newcode613 src/v8natives.js:613: function CallTrap1(handler, name, x, defaultTrap) { Maybe put ...

9 years, 5 months ago (2011-07-19 15:41:05 UTC) #2

Vitaly Repeshko

Drive by comment. Can you please mention in the description that this is for proxies? ...

9 years, 5 months ago (2011-07-19 16:01:59 UTC) #3

rossberg

9 years, 5 months ago (2011-07-21 11:08:42 UTC) #4

http://codereview.chromium.org/7436004/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7436004/diff/1/src/v8natives.js#newcode613
src/v8natives.js:613: function CallTrap1(handler, name, x, defaultTrap) {
On 2011/07/19 15:41:05, Mads Ager wrote:
> Maybe put the arguments last in the parameter list so it is always: (handler,
> name, defaultTrap, arg0, ...).
> 
> Ahhh, the default trap is optional. Can we require it and explicitly use "void
> 0" to pass undefined?

Done.

http://codereview.chromium.org/7436004/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7436004/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:496: TestHasOwn({
On 2011/07/19 15:41:05, Mads Ager wrote:
> Add whitespace between the calls?

Done, here and elsewhere.

Expand Messages | Collapse Messages