Pepper quota support

webkit/plugins/ppapi/plugin_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 #define WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 
 #include <string>
 
 #include "base/callback_old.h"
 #include "base/message_loop_proxy.h"
 #include "base/memory/ref_counted.h"
 #include "base/platform_file.h"
 #include "base/shared_memory.h"
 #include "base/sync_socket.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 #include "media/video/video_decode_accelerator.h"
 #include "ppapi/c/dev/pp_video_dev.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ui/gfx/size.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/plugins/ppapi/dir_contents.h"
+#include "webkit/quota/quota_client.h"
 
 class AudioMessageFilter;
 class GURL;
 class P2PSocketDispatcher;
 class SkBitmap;
 
 namespace base {
 class MessageLoopProxy;
 class Time;
 }
@@ skipping 250 matching lines @@
 
   // Notifies that the index of the currently selected item has been updated.
   virtual void SelectedFindResultChanged(int identifier, int index) = 0;
 
   // Runs a file chooser.
   virtual bool RunFileChooser(
       const WebKit::WebFileChooserParams& params,
       WebKit::WebFileChooserCompletion* chooser_completion) = 0;
 
   // Sends an async IPC to open a file.
-  typedef Callback2<base::PlatformFileError, base::PassPlatformFile
-                    >::Type AsyncOpenFileCallback;
+  typedef Callback3<base::PlatformFileError,
+                    base::PassPlatformFile,
+                    int64_t /* file_size */>::Type AsyncOpenFileCallback;

[michaeln, 2011/07/20 21:28:33]

How is this size used? There's no guarantee that it's accurate assuming that
others may be writing/truncating it.

[kinuko, 2011/07/21 14:34:08]

No, but I don't think we can strictly guarantee accurate counting in the current
model.  For WillWrite/WillSetLength it's almost impossible to perform
GetFileSize and Write/Truncate in a single task, and for untrusted writes by API
we still cannot avoid a stale size situation unless we flush after each Write
call, since we keep file descriptors opened for FileIO.

Anyway I dropped this size parameter from the OpenFile callback and modified the
code to perform GetFileInfo and Write as closely as possible.

   virtual bool AsyncOpenFile(const FilePath& path,
                              int flags,
                              AsyncOpenFileCallback* callback) = 0;
   virtual bool AsyncOpenFileSystemURL(const GURL& path,
                                       int flags,
                                       AsyncOpenFileCallback* callback) = 0;
 
   virtual bool OpenFileSystem(
       const GURL& url,
       fileapi::FileSystemType type,
@@ skipping 11 matching lines @@
                      fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
   virtual bool Delete(const GURL& path,
                       fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
   virtual bool Rename(const GURL& file_path,
                       const GURL& new_file_path,
                       fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
   virtual bool ReadDirectory(
       const GURL& directory_path,
       fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
 
+  // For quota handlings for FileIO API.
+  typedef Callback1<int64>::Type AvailableSpaceCallback;
+  virtual bool QueryAvailableSpace(

[michaeln, 2011/07/20 21:28:33]

Does the return value mean anything? I don't see the callsites checking it,
maybe there shouldn't be a return value.

[kinuko, 2011/07/21 14:34:08]

Done.

+      const GURL& origin,
+      quota::StorageType type,
+      AvailableSpaceCallback* callback) = 0;
+  virtual void NotifyStorageModified(quota::QuotaClient::ID client_id,
+                                     const GURL& origin,
+                                     quota::StorageType type,
+                                     int64 delta) = 0;
+
   virtual base::PlatformFileError OpenFile(const PepperFilePath& path,
                                            int flags,
                                            base::PlatformFile* file) = 0;
   virtual base::PlatformFileError RenameFile(const PepperFilePath& from_path,
                                              const PepperFilePath& to_path) = 0;
   virtual base::PlatformFileError DeleteFileOrDir(const PepperFilePath& path,
                                                   bool recursive) = 0;
   virtual base::PlatformFileError CreateDir(const PepperFilePath& path) = 0;
   virtual base::PlatformFileError QueryFile(const PepperFilePath& path,
                                             base::PlatformFileInfo* info) = 0;
@@ skipping 74 matching lines @@
   virtual base::SharedMemory* CreateAnonymousSharedMemory(uint32_t size) = 0;
 
   // Returns the current preferences.
   virtual ::ppapi::Preferences GetPreferences() = 0;
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_