Pepper quota support

webkit/fileapi/file_system_file_util_proxy.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_PROXY_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_PROXY_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 15 matching lines @@
 using base::MessageLoopProxy;
 using base::PlatformFile;
 using base::PlatformFileError;
 using base::PlatformFileInfo;
 
 // This class provides asynchronous access to common file routines for the
 // FileSystem API.
 class FileSystemFileUtilProxy {
  public:
   typedef base::FileUtilProxy::StatusCallback StatusCallback;
-  typedef base::FileUtilProxy::CreateOrOpenCallback CreateOrOpenCallback;
+  typedef Callback4<PlatformFileError /* error code */,
+                    base::PassPlatformFile,
+                    bool /* created */,
+                    int64 /* file_size */

[brettw, 2011/07/19 20:29:31]

Can you document what will happen on failure? Like if the error code is not
PLATFORM_FILE_OK, the size will be -1.

[kinuko, 2011/07/20 13:39:35]

Done.

+                    >::Type CreateOrOpenCallback;
   typedef base::FileUtilProxy::EnsureFileExistsCallback
     EnsureFileExistsCallback;
   typedef Callback3<PlatformFileError /* error code */,
                     const PlatformFileInfo& /* file_info */,
                     const FilePath& /* platform_path, where possible */
                     >::Type GetFileInfoCallback;
   typedef Callback2<PlatformFileError /* error code */,
                     const FilePath& /* local_path, where possible */
                     >::Type GetLocalPathCallback;
   typedef base::FileUtilProxy::ReadDirectoryCallback ReadDirectoryCallback;
 
-  // Creates or opens a file with the given flags.  It is invalid to pass NULL
-  // for the callback.
+  // Creates or opens a file with the given flags.  This also returns the

[brettw, 2011/07/19 20:29:31]

This comment initially confused me since this function doesn't return the size.
I think probably it's not necessary to mention the size, since the way you did
the callback is pretty obvious what types of data you get.

[kinuko, 2011/07/20 13:39:35]

Removed.

+  // file size for the opened file.
+  // It is invalid to pass NULL for the callback.
   // If PLATFORM_FILE_CREATE is set in |file_flags| it always tries to create
   // a new file at the given |file_path| and calls back with
   // PLATFORM_FILE_ERROR_FILE_EXISTS if the |file_path| already exists.
-  static bool CreateOrOpen(const FileSystemOperationContext& context,
-                           scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                           const FilePath& file_path,
-                           int file_flags,
-                           CreateOrOpenCallback* callback);
+  static bool CreateOrOpenAndQuerySize(
+      const FileSystemOperationContext& context,
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      const FilePath& file_path,
+      int file_flags,
+      CreateOrOpenCallback* callback);
 
   // Close the given file handle.
   static bool Close(const FileSystemOperationContext& context,
                     scoped_refptr<MessageLoopProxy> message_loop_proxy,
                     PlatformFile,
                     StatusCallback* callback);
 
   // Ensures that the given |file_path| exist.  This creates a empty new file
   // at |file_path| if the |file_path| does not exist.
   // If a new file han not existed and is created at the |file_path|,
@@ skipping 89 matching lines @@
       int64 length,
       StatusCallback* callback);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(FileSystemFileUtilProxy);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_PROXY_H_