chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 7432006: Add an experimental permissions API for extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 7432006: Add an experimental permissions API for extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_prefs.cc ('K') | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/extensions/api/extension_api.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 1bf6d8fe4d5c93345d85d5d6a113090488461232..b5c8a1ee7491bcf029289c40172f3a234e838b58 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -275,8 +275,10 @@ std::wstring ExtensionInstallDialogView::GetDialogButtonLabel(

case MessageBoxFlags::DIALOGBUTTON_OK:

return UTF16ToWide(

l10n_util::GetStringUTF16(ExtensionInstallUI::kButtonIds[type_]));

- case MessageBoxFlags::DIALOGBUTTON_CANCEL:

- return UTF16ToWide(l10n_util::GetStringUTF16(IDS_CANCEL));

+ case MessageBoxFlags::DIALOGBUTTON_CANCEL: {

+ int id = ExtensionInstallUI::kAbortButtonIds[type_];

+ return UTF16ToWide(l10n_util::GetStringUTF16(id > 0 ? id : IDS_CANCEL));

+ }

default:

NOTREACHED();

return std::wstring();