Send mouse events to the renderer before changing mouse capture, so that the ...

chrome/browser/renderer_host/render_widget_host_view_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_win.h"
 
 #include "app/gfx/canvas.h"
 #include "app/gfx/gdi_util.h"
 #include "app/l10n_util.h"
 #include "app/l10n_util_win.h"
@@ skipping 1539 matching lines @@
 }
 
 void RenderWidgetHostViewWin::ForwardMouseEventToRenderer(UINT message,
                                                           WPARAM wparam,
                                                           LPARAM lparam) {
   if (!render_widget_host_)
     return;
 
   WebMouseEvent event(
       WebInputEventFactory::mouseEvent(m_hWnd, message, wparam, lparam));
+
+  // Send the event to the renderer before changing mouse capture, so that the
+  // capturelost event arrives after mouseup.
+  render_widget_host_->ForwardMouseEvent(event);

[darin (slow to review), 2010/03/10 00:14:06]

LGTM

I think you should make a similar change to WebWidgetHost::MouseEvent.

[jam, 2010/03/10 01:51:19]

good idea, thanks.  will add it and commit.

+
   switch (event.type) {
     case WebInputEvent::MouseMove:
       TrackMouseLeave(true);
       break;
     case WebInputEvent::MouseLeave:
       TrackMouseLeave(false);
       break;
     case WebInputEvent::MouseDown:
       SetCapture();
       break;
     case WebInputEvent::MouseUp:
       if (GetCapture() == m_hWnd)
         ReleaseCapture();
       break;
   }
 
-  render_widget_host_->ForwardMouseEvent(event);
-
   if (activatable_ && event.type == WebInputEvent::MouseDown) {
     // This is a temporary workaround for bug 765011 to get focus when the
     // mouse is clicked. This happens after the mouse down event is sent to
     // the renderer because normally Windows does a WM_SETFOCUS after
     // WM_LBUTTONDOWN.
     SetFocus();
   }
 }
 
 void RenderWidgetHostViewWin::ShutdownHost() {
   shutdown_factory_.RevokeAll();
   if (render_widget_host_)
     render_widget_host_->Shutdown();
   // Do not touch any members at this point, |this| has been deleted.
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView native_view) {
   if (::IsWindow(native_view)) {
     HANDLE raw_render_host_view = ::GetProp(native_view,
                                             kRenderWidgetHostViewKey);
     if (raw_render_host_view)
       return reinterpret_cast<RenderWidgetHostView*>(raw_render_host_view);
   }
   return NULL;
 }