Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 7421003: ICU 4.6 NumberFormat::EStyle enum is gone in ICU 4.8. Adding #if #else to make it work across ver... (Closed)

Created:
9 years, 5 months ago by Nebojša Ćirić
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

ICU 4.6 NumberFormat::EStyle enum is gone in ICU 4.8. Adding #if #else to make it work across versions. There was an ICU cleanup (removing all C++ style enums and replacing them with plain C enums). NumberFormat::EStyle had a draft status (from ICU 4.2) and it was cut. Confusion came up because DateFormat::EStyle is stable and won't be removed. TEST=Compile Chromium with ICU 4.6 and ICU 4.8 BUG=1561 Committed: http://code.google.com/p/v8/source/detail?r=8701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/extensions/experimental/number-format.cc View 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nebojša Ćirić
9 years, 5 months ago (2011-07-19 01:28:26 UTC) #1
Mads Ager (chromium)
LGTM, but please wait for Jungshik's review.
9 years, 5 months ago (2011-07-19 09:15:48 UTC) #2
jungshik at Google
9 years, 5 months ago (2011-07-19 20:23:44 UTC) #3
LGTM !

Powered by Google App Engine
This is Rietveld 408576698