Issue 7420: No more failures than before. It is ready to be reviewed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7420: No more failures than before. It is ready to be reviewed. (Closed)

Created:
12 years, 2 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

No more failures than before. It is ready to be reviewed. Committed: http://code.google.com/p/v8/source/detail?r=544

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -43 lines)			Patch
M	src/builtins-arm.cc	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/codegen-arm.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View	1 2	5 chunks	+20 lines, -8 lines	0 comments	Download
M	src/ic-arm.cc	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/macro-assembler-arm.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/macro-assembler-arm.cc	View	1 2	3 chunks	+52 lines, -17 lines	0 comments	Download
M	src/stub-cache-arm.cc	View	1 2	3 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iposva

Does it lint? Aside from the comments below it LGTM. -Ivan http://codereview.chromium.org/7420/diff/201/402 File src/builtins-arm.cc (right): ...

12 years, 2 months ago (2008-10-21 20:06:45 UTC) #2

Feng Qian

12 years, 2 months ago (2008-10-21 20:11:26 UTC) #3

Fixed lint issue I can find.

http://codereview.chromium.org/7420/diff/201/402
File src/builtins-arm.cc (right):

http://codereview.chromium.org/7420/diff/201/402#newcode479
Line 479: Context::kHeaderSize + Context::GLOBAL_INDEX * kPointerSize;
On 2008/10/21 20:06:45, iposva wrote:
> It looks as if this is indented wrong. Should be 4 characters, no?
> 

Done.

http://codereview.chromium.org/7420/diff/201/405
File src/macro-assembler-arm.cc (right):

http://codereview.chromium.org/7420/diff/201/405#newcode693
Line 693: // restore ip to holder's context
On 2008/10/21 20:06:45, iposva wrote:
> Please use . at the end of the comment and capitalize the sentence.

Done.

Expand Messages | Collapse Messages