Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/resources/print_preview/print_preview_cloud.js

Issue 7408004: Printer dropdown cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review related changes Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview_cloud.js
diff --git a/chrome/browser/resources/print_preview/print_preview_cloud.js b/chrome/browser/resources/print_preview/print_preview_cloud.js
index c1908f8ec979a39142875234e06ad9758f30c8a6..f48db09ece65794edb1c843a593ea9db6b4df48b 100644
--- a/chrome/browser/resources/print_preview/print_preview_cloud.js
+++ b/chrome/browser/resources/print_preview/print_preview_cloud.js
@@ -119,12 +119,12 @@ cr.define('cloudprint', function() {
var searchResult = JSON.parse(xhr.responseText);
if (searchResult['success']) {
var printerList = searchResult['printers'];
- callback.call(this, printerList, false);
+ callback.call(this, printerList);
} else {
- callback.call(this, null, false);
+ callback.call(this, null);
}
} else {
- callback.call(this, null, false);
+ callback.call(this, null);
}
}
@@ -305,7 +305,7 @@ cr.define('cloudprint', function() {
cloud_print_data,
add_callback,
update_caps_callback) {
- var printer = add_callback([JSON.parse(cloud_print_data)], false);
+ var printer = add_callback([JSON.parse(cloud_print_data)]);
if (printer)
update_caps_callback(printer);
}
@@ -313,8 +313,8 @@ cr.define('cloudprint', function() {
/** Returns the data necessary to serialize a cloud print printer.
dpapad 2011/07/19 22:22:58 Please use the following format, here and elsewher
Albert Bodenhamer 2011/07/19 22:43:48 Done.
* @param {Object} printer The printer object to get data for.
* @return {string} A JSON string that can be used to recreate the
- * cloud print portion of the printer object, or
- * an empty string if there is no data to save.
+ * cloud print portion of the printer object, or
dpapad 2011/07/19 22:22:58 Nit: More can fit in this line.
Albert Bodenhamer 2011/07/19 22:43:48 Done.
+ * an empty string if there is no data to save.
*/
function getData(printer) {
if (isCloudPrint(printer)) {
@@ -336,7 +336,7 @@ cr.define('cloudprint', function() {
* @param {Object} printer The printer to mark.
* @param {string} name The user visible name of the printer.
* @param {string} id The id of the printer used by cloud print to
- * identify it.
+ * identify it.
*/
function setCloudPrint(printer, name, id) {
if (!printer.cloudPrintOptions) {

Powered by Google App Engine
This is Rietveld 408576698