Printer dropdown cleanup

chrome/browser/resources/print_preview/print_preview_cloud.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cloudprint', function() {
 
   // The URL to use to access the cloud print servers.
   // Set by a call to setBaseURL.
   var cloudPrintBaseURL = '';
 
@@ skipping 101 matching lines @@
   /**
    * Parse the response from the fetchPrinters call.
    * @param {function} callback Function to be called to process response.
    * @param {XMLHttpRequest} xhr The object used to make the request.
    */
   function fetchPrintersResponse(callback, xhr) {
     if (xhr.status == 200) {
       var searchResult = JSON.parse(xhr.responseText);
       if (searchResult['success']) {
         var printerList = searchResult['printers'];
-        callback.call(this, printerList, false);
+        callback.call(this, printerList);
       } else {
-        callback.call(this, null, false);
+        callback.call(this, null);
       }
     } else {
-      callback.call(this, null, false);
+      callback.call(this, null);
     }
   }
 
   /**
    * Retrieve the list of printers available via cloud print.
    * @param {function} callback Function to be called to process response.
    */
   function fetchPrinters(callback, all) {
    var query = 'q=^recent';
    if (all) {
@@ skipping 160 matching lines @@
    * @param {Object} cloud_print_data Data to be stored in cloudPrintOptions.
    * @param {function} add_callback The callback to be called to add the new
    *                   printer to the print preview UI.
    * @param {function} update_caps_callback The callback to be called to update
    *                   capabilities on the new printer.
    */
   function setDefaultPrinter(printer_name,
                              cloud_print_data,
                              add_callback,
                              update_caps_callback) {
-    var printer = add_callback([JSON.parse(cloud_print_data)], false);
+    var printer = add_callback([JSON.parse(cloud_print_data)]);
     if (printer)
       update_caps_callback(printer);
   }
 
   /** Returns the data necessary to serialize a cloud print printer.

[dpapad, 2011/07/19 22:22:58]

Please use the following format, here and elsewhere.
/**
 * Comments go here.
 */

[Albert Bodenhamer, 2011/07/19 22:43:48]

Done.

    * @param {Object} printer The printer object to get data for.
    * @return {string} A JSON string that can be used to recreate the
-   *                  cloud print portion of the printer object, or
-   *                  an empty string if there is no data to save.
+   *     cloud print portion of the printer object, or

[dpapad, 2011/07/19 22:22:58]

Nit: More can fit in this line.

[Albert Bodenhamer, 2011/07/19 22:43:48]

Done.

+   *     an empty string if there is no data to save.
    */
   function getData(printer) {
     if (isCloudPrint(printer)) {
       return JSON.stringify(printer.cloudPrintOptions);
     } else {
       return "";
     }
   }
 
   /** Test if a printer is a cloud print printer.
    * @param {Object} printer The printer to test.
    * @return {boolean} true iff the printer is a cloud print printer.
    */
   function isCloudPrint(printer) {
     return printer && printer.cloudPrintOptions != null;
   }
 
   /** Mark a printer as a cloud print printer and record its name and id.
    * @param {Object} printer The printer to mark.
    * @param {string} name The user visible name of the printer.
    * @param {string} id The id of the printer used by cloud print to
-   *                 identify it.
+   *     identify it.
    */
   function setCloudPrint(printer, name, id) {
     if (!printer.cloudPrintOptions) {
       printer.cloudPrintOptions = new Object;
     }
     printer.cloudPrintOptions.name = name;
     printer.cloudPrintOptions.id = id;
   }
 
   return {
     colorIsDefault: colorIsDefault,
     fetchPrinters: fetchPrinters,
     getBaseURL: getBaseURL,
     getData: getData,
     getPrintTicketJSON: getPrintTicketJSON,
     isCloudPrint: isCloudPrint,
     printToCloud: printToCloud,
     setBaseURL: setBaseURL,
     setCloudPrint: setCloudPrint,
     setColor: setColor,
     setDefaultPrinter: setDefaultPrinter,
     supportsColor: supportsColor,
     updatePrinterCaps: updatePrinterCaps
   };
 });