chrome/browser/safe_browsing/client_side_detection_service.h - Issue 7408001: If we show a SafeBrowsing warning we always send the client-side detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 7408001: If we show a SafeBrowsing warning we always send the client-side detection (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Merge Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.h

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h

index f9d1c8bf42025a91c3a792685a7c0a5b2dc235f9..3fb5e496a13b0f165ab100cfb66b70a6f6c64299 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.h

+++ b/chrome/browser/safe_browsing/client_side_detection_service.h

@@ -85,7 +85,8 @@ class ClientSideDetectionService : public URLFetcher::Delegate,

// occurs during the fetch. If an error occurs the phishing verdict will

// always be false. The callback is always called after

// SendClientReportPhishingRequest() returns and on the same thread as

- // SendClientReportPhishingRequest() was called.

+ // SendClientReportPhishingRequest() was called. You may set |callback| to

+ // NULL if you don't care about the server verdict.

virtual void SendClientReportPhishingRequest(

ClientPhishingRequest* verdict,

ClientReportPhishingRequestCallback* callback);