Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 7408001: If we show a SafeBrowsing warning we always send the client-side detection (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index f94244d3ee8c6e21f3fbfc9203a3ae87221a8867..aa3d7610eadbe3963d16e00ec876cabe452ada2a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -1019,7 +1019,9 @@ void SafeBrowsingService::DoDisplayBlockingPage(
resource.is_subresource, resource.threat_type,
std::string() /* post_data */);
}
-
+ if (resource.threat_type != SafeBrowsingService::SAFE) {
+ FOR_EACH_OBSERVER(Observer, observer_list_, OnSafeBrowsingHit(resource));
+ }
SafeBrowsingBlockingPage::ShowBlockingPage(this, resource);
}
@@ -1049,6 +1051,14 @@ void SafeBrowsingService::ReportSafeBrowsingHit(
post_data));
}
+void SafeBrowsingService::AddObserver(Observer* observer) {
mattm 2011/07/19 21:25:55 Add thread DCHECKS?
noelutz 2011/07/19 22:28:08 Done.
+ observer_list_.AddObserver(observer);
+}
+
+void SafeBrowsingService::RemoveObserver(Observer* observer) {
+ observer_list_.RemoveObserver(observer);
+}
+
void SafeBrowsingService::ReportSafeBrowsingHitOnIOThread(
const GURL& malicious_url,
const GURL& page_url,

Powered by Google App Engine
This is Rietveld 408576698