If we show a SafeBrowsing warning we always send the client-side detection

chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
 
 #include <set>
 
 #include "base/callback.h"
 #include "base/lazy_instance.h"
@@ skipping 181 matching lines @@
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PhishingClassifierDelegate::ClassificationDone(
     const ClientPhishingRequest& verdict) {
   // We no longer need the page text.
   classifier_page_text_.clear();
   VLOG(2) << "Phishy verdict = " << verdict.is_phishing()
           << " score = " << verdict.client_score();
-  if (!verdict.is_phishing()) {
-    return;
+  if (verdict.client_score() != PhishingClassifier::kInvalidScore) {
+    DCHECK(last_url_sent_to_classifier_.spec() == verdict.url());

[Brian Ryner, 2011/07/19 21:27:10]

Maybe switch this to DCHECK_EQ while you're here?

[noelutz, 2011/07/19 22:28:08]

Done.

+    Send(new SafeBrowsingHostMsg_PhishingDetectionDone(
+        routing_id(), verdict.SerializeAsString()));
   }
-  DCHECK(last_url_sent_to_classifier_.spec() == verdict.url());
-  Send(new SafeBrowsingHostMsg_DetectedPhishingSite(
-      routing_id(), verdict.SerializeAsString()));
 }
 
 GURL PhishingClassifierDelegate::GetToplevelUrl() {
   return render_view()->webview()->mainFrame()->document().url();
 }
 
 void PhishingClassifierDelegate::MaybeStartClassification() {
   // We can begin phishing classification when the following conditions are
   // met:
   //  1. A Scorer has been created
@@ skipping 54 matching lines @@
 
   VLOG(2) << "Starting classification for " << last_finished_load_url_;
   last_url_sent_to_classifier_ = last_finished_load_url_;
   is_classifying_ = true;
   classifier_->BeginClassification(
       &classifier_page_text_,
       NewCallback(this, &PhishingClassifierDelegate::ClassificationDone));
 }
 
 }  // namespace safe_browsing