If we show a SafeBrowsing warning we always send the client-side detection

chrome/browser/safe_browsing/safe_browsing_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #pragma once
 
 #include <deque>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/observer_list.h"
 #include "base/synchronization/lock.h"
 #include "base/task.h"
 #include "base/time.h"
 #include "chrome/browser/safe_browsing/safe_browsing_util.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "googleurl/src/gurl.h"
 
 class MalwareDetails;
 class PrefService;
@@ skipping 67 matching lines @@
     // this class.
     // TODO(lzheng): We should consider to use this time out check
     // for browsing too (instead of implementin in
     // safe_browsing_resource_handler.cc).
     CancelableTask* timeout_task;
 
    private:
     DISALLOW_COPY_AND_ASSIGN(SafeBrowsingCheck);
   };
 
+  // Observer class can be used to get notified when a SafeBrowsing hit
+  // was found.
+  class Observer {
+   public:
+    Observer() {}

[Brian Ryner, 2011/07/19 21:27:10]

Since this should always be subclassed, make the ctor and dtor protected?

[noelutz, 2011/07/19 22:28:08]

Done.

+    virtual ~Observer() {}
+    // The |resource| must not be accessed after OnSafeBrowsingHit returns.
+    // This method will be called on the UI thread.
+    virtual void OnSafeBrowsingHit(const UnsafeResource& resource) = 0;
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(Observer);
+  };
+
   class Client {
    public:
     virtual ~Client() {}
 
     void OnSafeBrowsingResult(const SafeBrowsingCheck& check);
 
     // Called when the user has made a decision about how to handle the
     // SafeBrowsing interstitial page.
     virtual void OnBlockingPageComplete(bool proceed) {}
 
    protected:
     // Called when the result of checking a browse URL is known.
     virtual void OnBrowseUrlCheckResult(const GURL& url,
                                         UrlCheckResult result) {}
 
     // Called when the result of checking a download URL is known.
     virtual void OnDownloadUrlCheckResult(const std::vector<GURL>& url_chain,
                                           UrlCheckResult result) {}
 
     // Called when the result of checking a download binary hash is known.
     virtual void OnDownloadHashCheckResult(const std::string& hash,
                                            UrlCheckResult result) {}
   };
 
-
   // Makes the passed |factory| the factory used to instanciate
   // a SafeBrowsingService. Useful for tests.
   static void RegisterFactory(SafeBrowsingServiceFactory* factory) {
     factory_ = factory;
   }
 
   // Create an instance of the safe browsing service.
   static SafeBrowsingService* CreateSafeBrowsingService();
 
   // Called on the UI thread to initialize the service.
@@ skipping 113 matching lines @@
   // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
   // to the server. Can only be called on UI thread.  If |post_data| is
   // non-empty, the request will be sent as a POST instead of a GET.
   virtual void ReportSafeBrowsingHit(const GURL& malicious_url,
                                      const GURL& page_url,
                                      const GURL& referrer_url,
                                      bool is_subresource,
                                      UrlCheckResult threat_type,
                                      const std::string& post_data);
 
+  // Add and remove observers.  These methods must be invoked on the UI thread.
+  void AddObserver(Observer* observer);
+  void RemoveObserver(Observer* remove);
+
  protected:
   // Creates the safe browsing service.  Need to initialize before using.
   SafeBrowsingService();
 
   virtual ~SafeBrowsingService();
 
  private:
   friend class SafeBrowsingServiceFactoryImpl;
 
   typedef std::set<SafeBrowsingCheck*> CurrentChecks;
@@ skipping 198 matching lines @@
 
   std::deque<QueuedCheck> queued_checks_;
 
   // When download url check takes this long, client's callback will be called
   // without waiting for the result.
   int64 download_urlcheck_timeout_ms_;
 
   // Similar to |download_urlcheck_timeout_ms_|, but for download hash checks.
   int64 download_hashcheck_timeout_ms_;
 
+  ObserverList<Observer> observer_list_;
   NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
 };
 
 // Factory for creating SafeBrowsingService.  Useful for tests.
 class SafeBrowsingServiceFactory {
  public:
   SafeBrowsingServiceFactory() { }
   virtual ~SafeBrowsingServiceFactory() { }
   virtual SafeBrowsingService* CreateSafeBrowsingService() = 0;
  private:
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingServiceFactory);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_