Don't use X509Certificate in SSLConfig.

net/http/http_stream_factory_impl_job.cc

Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 895266891977b8481f3c0bf0d55bea2426defc39..b040359dfa90f54a233504a937d0be14d92f5ed2 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -1013,7 +1013,9 @@ int HttpStreamFactoryImpl::Job::HandleCertificateError(int error) {
   // RestartIgnoringLastError(). And the user will be asked interactively
   // before RestartIgnoringLastError() is ever called.
   SSLConfig::CertAndStatus bad_cert;
-  bad_cert.cert = ssl_info_.cert;
+  if (ssl_info_.cert == NULL ||
+      !ssl_info_.cert->GetDEREncoded(&bad_cert.cert_der))
+    return error;

[wtc, 2011/07/19 21:57:01]

Are you sure ssl_info_.cert may be NULL here?  I don't
think this function is executed in the sandbox.

Please add a comment to explain why ssl_info.cert may be
NULL.

[Sergey Ulanov, 2011/07/19 23:50:21]

Normally ssl_info.cert should not be set to NULL, but there might be some cases
when it is NULL. We may fail to create X509Certificate for reasons other than
running in sandbox, for example when OS runs out of disk space, etc. - we don't
want chrome to crash in that case. Added comments.

   bad_cert.cert_status = ssl_info_.cert_status;
   ssl_config_.allowed_bad_certs.push_back(bad_cert);